From owner-freebsd-perl@FreeBSD.ORG Mon Jul 7 18:50:31 2014 Return-Path: Delivered-To: perl@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 18B0283B; Mon, 7 Jul 2014 18:50:31 +0000 (UTC) Received: from mail-we0-x22c.google.com (mail-we0-x22c.google.com [IPv6:2a00:1450:400c:c03::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 352E024D3; Mon, 7 Jul 2014 18:50:30 +0000 (UTC) Received: by mail-we0-f172.google.com with SMTP id u57so4871926wes.17 for ; Mon, 07 Jul 2014 11:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Vo/MXRsSSkyi1Rb/4e8Ucac2IDsEWE0TftFFt0qSoVE=; b=pz4pBIfpfZzfHW7FfKDIGegyhBCHp84Pqr9W1Vja4+z8HD/L0GPzLBvFQdwHYJiLW6 k2w0xO4Yc0p3jOlZSN2SBoVGBzlpy6V3/m7xu9t+0DWfPmdpHWVxk7mTJGgCUuQXq3G7 fKDNxg99VFGsAuj7IxaIr/oiSgFHiW9JHVocG7qEf0mNPtzb8Ex5JAAxmWFyyVtXyCAh /gpY9c5Mng6xPT64KQ2LFua3CqOhDPYhH6QlRhnXALd7ZML9irLn0pOW3bZUSHjT2Fuv t+WE4j5NmIVuipG9RpEr2LzP8UKag/MZ1FlHtrDaG7egoDixffDLh1Z1KtcCtrPf/VuZ TwCw== X-Received: by 10.194.6.134 with SMTP id b6mr35263168wja.64.1404759028519; Mon, 07 Jul 2014 11:50:28 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id lb3sm5823820wjc.30.2014.07.07.11.50.27 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Jul 2014 11:50:27 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 7 Jul 2014 20:50:25 +0200 From: Baptiste Daroussin To: Ryan Steinmetz Subject: Re: p5-Git-Repository Message-ID: <20140707185025.GC97203@ivaldir.etoilebsd.net> References: <53BA9AD8.7030906@myarcher.net> <20140707134409.GA12289@exodus.zi0r.com> <20140707161318.GB74596@exodus.zi0r.com> <20140707161913.GB97203@ivaldir.etoilebsd.net> <20140707162734.GC74596@exodus.zi0r.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uXxzq0nDebZQVNAZ" Content-Disposition: inline In-Reply-To: <20140707162734.GC74596@exodus.zi0r.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Mathieu Arnold , Barrie Archer , perl@freebsd.org, portmgr@freebsd.org X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jul 2014 18:50:31 -0000 --uXxzq0nDebZQVNAZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 07, 2014 at 12:27:34PM -0400, Ryan Steinmetz wrote: >=20 > On (07/07/14 18:19), Baptiste Daroussin wrote: > >On Mon, Jul 07, 2014 at 12:13:18PM -0400, Ryan Steinmetz wrote: > >> > >> On (07/07/14 17:55), Mathieu Arnold wrote: > >> >+--On 7 juillet 2014 09:44:09 -0400 Ryan Steinmetz w= rote: > >> >| We should either add workarounds for older systems or a warning > >> >| that will be printed if a user is running a FreeBSD release that la= cks > >> >| required functionality for the ports tree to function. > >> > > >> >Well, the ports tree is only guaranteed to work with supported FreeBSD > >> >releases. So, if you're not running a supported release, you're on yo= ur own. > >> > > >> >We can't add bits and pieces of version checks around everything that= won't > >> >work with older releases. > >> > >> We know what the supported releases are and we can easily add a check > >> to the framework to verify that you are running a supported release and > >> print a message if not. This would be identical to what was done with > >> the PKGNG checks/warnings. > >> > >> The goal is to give the user a useful message ("You are using an > >> unsupported version, please upgrade.") versus the errors that Barrie r= an > >> into ("Unknown modifier 't'" or "make: fatal errors encountered -- can= not continue"). > > > >Except that is that case it is impossible to catch it reliably, some imp= ossible > >to warn about it. >=20 > We don't need to catch anything. We simply need: >=20 > .if (${OSVERSION} >=3D 902510 && ${OSVERSION} < 1000000) || ${OSVERSION} = >=3D 1000704 > ${ECHO} "You are using an unsupported release. The ports tree may not > function correctly. Please update to a supported release for the best > experience. See http://.....freebsd.org/... for a list of supported > releases. > .endif >=20 > Obviously the versions are not correct, but, again, the goal is to give > people something to work with. Just like what we did with the PKGNG > warnings. >=20 > -r >=20 that won t work because you will have a syntax error before being able to p= rint that Bapt --uXxzq0nDebZQVNAZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlO66/EACgkQ8kTtMUmk6EzT2gCeMuPzVLDURqKj+bfJoZr6D7bU c/sAnjDTP5CMok4FabHhIQN6s1SEor0k =BYBA -----END PGP SIGNATURE----- --uXxzq0nDebZQVNAZ--