From owner-svn-src-all@FreeBSD.ORG Sun Sep 7 21:32:32 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B37FB9A6; Sun, 7 Sep 2014 21:32:32 +0000 (UTC) Received: from smtp1.multiplay.co.uk (smtp1.multiplay.co.uk [85.236.96.35]) by mx1.freebsd.org (Postfix) with ESMTP id 752C61F3C; Sun, 7 Sep 2014 21:32:32 +0000 (UTC) Received: by smtp1.multiplay.co.uk (Postfix, from userid 65534) id BC6E220E7088A; Sun, 7 Sep 2014 21:32:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.multiplay.co.uk X-Spam-Level: X-Spam-Status: No, score=0.9 required=8.0 tests=AWL,BAYES_00,DOS_OE_TO_MX, FSL_HELO_NON_FQDN_1,RDNS_DYNAMIC autolearn=no version=3.3.1 Received: from r2d2 (82-69-141-170.dsl.in-addr.zen.co.uk [82.69.141.170]) by smtp1.multiplay.co.uk (Postfix) with ESMTP id 1392B20E70885; Sun, 7 Sep 2014 21:32:29 +0000 (UTC) Message-ID: From: "Steven Hartland" To: "Andriy Gapon" , "Slawa Olhovchenkov" References: <201401161324.s0GDOADB008512@svn.freebsd.org> <20140907155641.GB72244@zxy.spb.ru> <540CC991.3070604@FreeBSD.org> <00D872A5601148E8AB294954A163BEBD@multiplay.co.uk> Subject: Re: svn commit: r260713 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Date: Sun, 7 Sep 2014 22:32:33 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=response Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Sep 2014 21:32:32 -0000 ----- Original Message ----- From: "Steven Hartland" >> on 07/09/2014 18:56 Slawa Olhovchenkov said the following: >>> On Thu, Jan 16, 2014 at 01:24:10PM +0000, Andriy Gapon wrote: >>> >>>> Author: avg >>>> Date: Thu Jan 16 13:24:10 2014 >>>> New Revision: 260713 >>>> URL: http://svnweb.freebsd.org/changeset/base/260713 >>>> >>>> Log: >>>> fix a bug in ZFS mirror code for handling multiple DVAa >>>> >>>> The bug was introduced in r256956 "Improve ZFS N-way mirror read >>>> performance". >>>> The code in vdev_mirror_dva_select erroneously considers already >>>> tried DVAs for the next attempt. Thus, it is possible that a failing DVA >>>> would be retried forever. >>>> As a secondary effect, if the attempts fail with checksum error, then >>>> checksum error reports are accumulated until the original request >>>> ultimately fails or succeeds. But because retrying is going on indefinitely >>>> the cheksum reports accumulation will effectively be a memory leak. >>>> >>>> Reviewed by: gibbs >>>> MFC after: 13 days >>>> Sponsored by: HybridCluster >>> >>> No NFC yet >>> >> >> Is r256956 MFC-ed yet? > > Nope I missed it, have applied for both to be MFC'ed. Approval was granted, both have now been MFC'ed. Thanks Slawa for heads up that I missed that one. Regards Steve