From owner-svn-src-head@freebsd.org Mon Sep 23 20:28:39 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8EEDAFED5F; Mon, 23 Sep 2019 20:28:39 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46cbWB6SdMz4TT2; Mon, 23 Sep 2019 20:28:38 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd41.google.com with SMTP id h144so36747707iof.7; Mon, 23 Sep 2019 13:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yB/aGoFASdsxHtDiO/gHrkLhpDHQO6bT6smeKqU4D9Y=; b=qNE7W820u89ox/BmNYdchXHbImEGoHl3UHKgE2gXqT5Y1rgOerxwW51WVq3S2ZZBKz iDM+Zic1MEYkikS6+n5RtczfRo9ROvQC+GLXvfgddOXnTO2cC8+3+kBVuPeuTI7wWbqC WU6bYmPvWPBTMXFOSEaH8fvhExMepPU90x7VJhLh6HsBaOamiDbAzmk55x7ZGSVFekoz ilpLTLEH+S/5ZBmJhWwF2Yrxe26u0JaQeNyAIq1aNy2xg8ytZ5vN7Zt7Gh56MBiuuyTX 60mmgocdkS2161C/dONTOiWSKFBcJsTBRs04wwea61xV3Pa4eAKQXG7xGY8RPAhvnS+M W6tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=yB/aGoFASdsxHtDiO/gHrkLhpDHQO6bT6smeKqU4D9Y=; b=Bbf0HBcyWsXn6XbYrFdfH08YdUg4umte/pz1FbbFIFTEGElyCndwehmVVOw+1Jk1GJ 0F81gUOSM6U6DzCbSlByJUw4peWgwbqFkG4ZgMCBAZMHzLy2db66tyzyJynevYttqBea b4XiiHEh9GPPD3kEsmB/Rb1kZZLefNElwC9BkBCwbo0idnY63jtcRqBw6IQQi9Xub01x IHHuR5YHtx33J3dOf+VYpUphlwFKdvsKq665mJh123EKotNbnv0Q4pkz+c8IfA9wEvCJ n8O5kKPgfnYYOo5GT6aTCucQxTzOj49/Ve/fl2PBO76u45CLYE+Nwc5fz8+fPsRuf4sG bc8g== X-Gm-Message-State: APjAAAV+Tsi9DZW2gBvZXX6GrHgu+snFytw8zkrc09YdHatoVVj690pS 3aw2H1Z6uYS1sGmfBIHxdwXUrSEl X-Google-Smtp-Source: APXvYqxk7nmIuHGN+jwNVx4GClz/7idyuop3ZMjqp9VvFqf3PwKzXy/P2tKDwblggsNfJw5+yWOsxA== X-Received: by 2002:a5d:88c9:: with SMTP id i9mr1309830iol.269.1569270517817; Mon, 23 Sep 2019 13:28:37 -0700 (PDT) Received: from raichu (toroon0560w-lp140-01-69-159-39-167.dsl.bell.ca. [69.159.39.167]) by smtp.gmail.com with ESMTPSA id y17sm12248709ioa.52.2019.09.23.13.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2019 13:28:37 -0700 (PDT) Sender: Mark Johnston Date: Mon, 23 Sep 2019 16:28:34 -0400 From: Mark Johnston To: Warner Losh Cc: "Conrad E. Meyer" , src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r352623 - in head/sys: amd64/amd64 kern Message-ID: <20190923202834.GE15061@raichu> References: <201909231414.x8NEEh9e040728@repo.freebsd.org> <20190923190629.GD15061@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 46cbWB6SdMz4TT2 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=qNE7W820; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::d41 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.24 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[1.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.55)[ip: (2.16), ipnet: 2607:f8b0::/32(-2.64), asn: 15169(-2.20), country: US(-0.05)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Sep 2019 20:28:39 -0000 On Mon, Sep 23, 2019 at 10:13:14PM +0200, Warner Losh wrote: > On Mon, Sep 23, 2019, 9:06 PM Mark Johnston wrote: > > > On Mon, Sep 23, 2019 at 11:28:52AM -0700, Conrad Meyer wrote: > > > Hi Mark, > > > > > > On Mon, Sep 23, 2019 at 7:14 AM Mark Johnston wrote: > > > > > > > > Author: markj > > > > Date: Mon Sep 23 14:14:43 2019 > > > > New Revision: 352623 > > > > URL: https://svnweb.freebsd.org/changeset/base/352623 > > > > > > > > Log: > > > > Use elf_relocaddr() when handling R_X86_64_RELATIVE relocations. > > > > > > > > This is required for DPCPU and VNET data variable definitions to > > work when > > > > KLDs are linked as DSOs. R_X86_64_RELATIVE relocations should not > > appear > > > > in object files, so assert this in elf_relocaddr(). > > > > > > Is the goal to eventually link amd64 KLDs as DSOs? I might be > > > confusing the terminology, but I believe amd64 .ko's today are > > > unlinked ordinary object files, rather than shared objects. (I > > > believe they use kern/link_elf_obj.c rather than kern/link_elf.c > > > today.) > > > > > > If so: great! > > > > That's right, and that is indeed my goal. At least, I would like to > > make the option available; with my patch set, it is possible to specify > > the format at both the per-module and global levels. There are several > > in-tree modules (some of the HighPoint RAID drivers, if you're curious) > > that cannot be linked as DSOs because they contain a non-PIC blob, and > > for now lld refuses to link them into a DSO. > > > > That problem might be better solved by removing the highpount driver since > they are old and abandon ware these days. I'm serious here, old stuff with > low value getting in the way might be better off in our rearview mirror... Well, there are at least four drivers. I'm not sure which, if any, are actively used these days, though some of them have gotten vendor updates in the past several years. In any case, handling the issue involved adding a single line to each driver's makefile, so I don't feel too oppressed.