From owner-svn-src-all@freebsd.org  Thu Aug  3 21:57:44 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02B01DD5643;
 Thu,  3 Aug 2017 21:57:44 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id D5B176CD13;
 Thu,  3 Aug 2017 21:57:43 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 2A66CFBBA; Thu,  3 Aug 2017 21:57:43 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Konstantin Belousov <kib@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r318780 - in head: include sys/sys
References: <201705240925.v4O9PDsZ026682@repo.freebsd.org>
Date: Thu, 03 Aug 2017 23:57:39 +0200
In-Reply-To: <201705240925.v4O9PDsZ026682@repo.freebsd.org> (Konstantin
 Belousov's message of "Wed, 24 May 2017 09:25:13 +0000 (UTC)")
Message-ID: <r2ws-2u24-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Aug 2017 21:57:44 -0000

Konstantin Belousov <kib@FreeBSD.org> writes:

> -#ifndef _POSIX_SOURCE
> +#if __BSD_VISIBLE
>  #define	ONLCR		0x00000002	/* map NL to CR-NL (ala CRMOD) */

This caused a regression for apps building with _XOPEN_SOURCE e.g.,
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220843

DragonFly uses __XSI_VISIBLE for ONLCR and other XSI extensions.
https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/e08b3836c962
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/termios.h.html