Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Nov 2018 14:03:18 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Yuri Victorovich <yuri@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r485467 - in head/math/mkl-dnn: . files
Message-ID:  <20181121130318.soq22a7uwqmt6xnh@ogg.in.absolight.net>
In-Reply-To: <201811201921.wAKJLEIi073906@repo.freebsd.org>
References:  <201811201921.wAKJLEIi073906@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--zdbjig5gkrb6ng3v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 20, 2018 at 07:21:14PM +0000, Yuri Victorovich wrote:
> Author: yuri
> Date: Tue Nov 20 19:21:14 2018
> New Revision: 485467
> URL: https://svnweb.freebsd.org/changeset/ports/485467
>=20
> Log:
>   math/mkl-dnn: Update 0.16 -> 0.17
>  =20
>   Port changes:
>   * Add the OPENMP option

This probably is a problem:

[00:03:29] Warning: (math/mkl-dnn): sh: clang70: not found
[00:03:29] Warning: (math/mkl-dnn): make: "/home/mat/work/freebsd/ports/Mk/=
Uses/compiler.mk" line 78: warning: "clang70 --version" returned non-zero s=
tatus
[00:03:29] Warning: (math/mkl-dnn): make: "/home/mat/work/freebsd/ports/Mk/=
Uses/compiler.mk" line 133: warning: "clang++70 -### /dev/null 2>&1" return=
ed non-zero status

> Modified:
>   head/math/mkl-dnn/Makefile
>   head/math/mkl-dnn/distinfo
>   head/math/mkl-dnn/files/patch-CMakeLists.txt
>=20
> Modified: head/math/mkl-dnn/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/math/mkl-dnn/Makefile	Tue Nov 20 19:19:21 2018	(r485466)
> +++ head/math/mkl-dnn/Makefile	Tue Nov 20 19:21:14 2018	(r485467)
> @@ -2,7 +2,7 @@
> =20
>  PORTNAME=3D	mkl-dnn
>  DISTVERSIONPREFIX=3D	v
> -DISTVERSION=3D	0.16
> +DISTVERSION=3D	0.17
>  CATEGORIES=3D	math
> =20
>  MAINTAINER=3D	yuri@FreeBSD.org
> @@ -26,9 +26,20 @@ PLIST_FILES=3D	include/mkldnn.h \
>  		include/mkldnn_types.h \
>  		lib/libmkldnn.so \
>  		lib/libmkldnn.so.0 \
> -		lib/libmkldnn.so.0.16.0
> +		lib/libmkldnn.so.${DISTVERSION}.0
> =20
> -do-test:
> +OPTIONS_DEFINE=3D		OPENMP
> +
> +OPENMP_CMAKE_BOOL=3D	USE_OPENMP
> +OPENMP_LIB_DEPENDS=3D	libomp.so:devel/openmp
> +
> +# use clang from ports because cmake can't find OpenMP with base clang, =
see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223678
> +BUILD_DEPENDS+=3D	clang${LLVM_DEFAULT}:devel/llvm${LLVM_DEFAULT}
> +CPP=3D		clang-cpp${LLVM_DEFAULT}
> +CC=3D		clang${LLVM_DEFAULT}
> +CXX=3D		clang++${LLVM_DEFAULT}

The comment says clang from ports is needed for the OpenMP option, but
its use is not dependant on the option, this is confusing.

> +
> +do-test: # some tests are known to fail: https://github.com/intel/mkl-dn=
n/issues/350
>  	@${REINPLACE_CMD} 's| /bin/bash | ${LOCALBASE}/bin/bash |' ${WRKSRC}/te=
sts/CMakeLists.txt
>  	@cd ${BUILD_WRKSRC} && \
>  		${SETENV} ${CONFIGURE_ENV} ${CMAKE_BIN} ${CMAKE_ARGS} -DBUILD_TESTS=3D=
ON ${CMAKE_SOURCE_PATH} && \
>=20
> Modified: head/math/mkl-dnn/distinfo
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/math/mkl-dnn/distinfo	Tue Nov 20 19:19:21 2018	(r485466)
> +++ head/math/mkl-dnn/distinfo	Tue Nov 20 19:21:14 2018	(r485467)
> @@ -1,3 +1,3 @@
> -TIMESTAMP =3D 1536106132
> -SHA256 (intel-mkl-dnn-v0.16_GH0.tar.gz) =3D 7557f820d6801dbe7741627199c0=
165fe9e651245b9c1c744d615f576da1098a
> -SIZE (intel-mkl-dnn-v0.16_GH0.tar.gz) =3D 1339496
> +TIMESTAMP =3D 1542731420
> +SHA256 (intel-mkl-dnn-v0.17_GH0.tar.gz) =3D 3473da3b486934da169895a7efd6=
421482d274601c0aed3505b127971f233a07
> +SIZE (intel-mkl-dnn-v0.17_GH0.tar.gz) =3D 1413454
>=20
> Modified: head/math/mkl-dnn/files/patch-CMakeLists.txt
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/math/mkl-dnn/files/patch-CMakeLists.txt	Tue Nov 20 19:19:21 2018=
	(r485466)
> +++ head/math/mkl-dnn/files/patch-CMakeLists.txt	Tue Nov 20 19:21:14 2018=
	(r485467)
> @@ -1,6 +1,17 @@
> ---- CMakeLists.txt.orig	2018-09-05 00:11:53 UTC
> +--- CMakeLists.txt.orig	2018-11-17 00:02:10 UTC
>  +++ CMakeLists.txt
> -@@ -69,7 +69,10 @@ enable_testing()
> +@@ -66,7 +66,9 @@ set(CMAKE_TEST_CCXX_FLAGS)      # TESTS=20
> +=20
> + include("cmake/utils.cmake")
> + include("cmake/options.cmake")
> +-include("cmake/OpenMP.cmake")
> ++if (USE_OPENMP)
> ++  include("cmake/OpenMP.cmake")
> ++endif()
> + include("cmake/TBB.cmake")
> + include("cmake/platform.cmake")
> + include("cmake/SDL.cmake")
> +@@ -79,7 +81,10 @@ enable_testing()
>   include_directories(include)
>  =20
>   add_subdirectory(src)
>=20
>=20

--=20
Mathieu Arnold

--zdbjig5gkrb6ng3v
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlv1V5RfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkioKA//VA2CRpUrNCdaRfcJCfjwA6X2Spo2DroUWJSuBO1JrEDGpt4Z2R1upcFk
kwCh91mnj//oHBw4rKNUVhP3nOEMqd1Y0t1hEhFWhgBgLk63U4ZRmhsCGEk7INe9
v/+16g5uzHRviBz4mBFkwdp1yNgYkNgvW7qSNnBXqIdN5t73T4NsFlnWWwVo1qyB
lTQhD+ZeSHoZ8s2n42IM2ApkLcIzpUPMElsHCs+lg01YO/RHmzWUkL/u9b8vuv/d
q8qPssXTbQ0/HYUYI1F5T+GQt2V4nnLu7zqHepAeD+zlpZywn2tatPiUfrYJ9b6p
iNY9MXwSyXlMAdcdjgAoAPTq+WUz8koxgs112qcH7kyFgfP+RsRk9hZfGY9Y5wlC
SrfRvpRB8BNXq3NR6SmvAWGKkHKhLStTtD7eDeJWk+KVBn0uCQrhDIfI03VFuyO2
/AO6aDBjaePBl91bCcTNVAzqGOK5ImG9P3J3up67JeogRwp6zNCUb8X/EFho0W5G
Ow+grFU0PlOeBImSu04ZgSJMt2MZyQ5yQx/JN62GuoawaBoMWGvWD+64Sed/dWj2
RvBQY6Y9PRc2jBCjstUy3PcicfpHosC+Q6F4eav01VmCvVYvwN0xjc0CH3g48WDn
XXzjwrupqAz7+/tXGMMFzW3DaGO7OZqAVEisCwRoRSOH9xol46E=
=2Q0M
-----END PGP SIGNATURE-----

--zdbjig5gkrb6ng3v--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181121130318.soq22a7uwqmt6xnh>