From owner-svn-ports-all@FreeBSD.ORG  Sun May  5 15:06:40 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 5CB6D2B0;
 Sun,  5 May 2013 15:06:40 +0000 (UTC)
 (envelope-from makc@freebsd.org)
Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3])
 by mx1.freebsd.org (Postfix) with ESMTP id DA16C145;
 Sun,  5 May 2013 15:06:39 +0000 (UTC)
Received: from mercury.ph.man.ac.uk [130.88.75.175:57502] (HELO/EHLO
 mercury.ph.man.ac.uk, authenticated with LOGIN)
 by mail.issp.ac.ru with ESMTP/inet id r45F4CO2033226 (using TLSv1/SSLv3,
 with cipher DHE-RSA-AES256-SHA (256 bits), verified NO)
 Sun, 5 May 2013 19:04:13 +0400 (MSK)
From: Max Brazhnikov <makc@freebsd.org>
To: Raphael Kubo da Costa <rakuco@freebsd.org>
Subject: Re: svn commit: r317266 - head/multimedia/gst123
Date: Sun, 05 May 2013 15:06:04 +0000
Message-ID: <1607117.RnIN0iR8p5@mercury.ph.man.ac.uk>
User-Agent: KMail/4.10.2 (FreeBSD/9.1-STABLE; KDE/4.10.2; amd64; ; )
In-Reply-To: <201305032136.r43LaTYo048658@svn.freebsd.org>
References: <201305032136.r43LaTYo048658@svn.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Cc: svn-ports-head@freebsd.org, h.skuhra@gmail.com, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 May 2013 15:06:40 -0000

Hi,

On Fri, 03 May 2013 21:36:29 +0000Fri May  3 21:36:29 2013 Raphael Kubo da Costa wrote:
> Author: rakuco
> Date: Fri May  3 21:36:29 2013
> New Revision: 317266
> URL: http://svnweb.freebsd.org/changeset/ports/317266
> 
> Log:
>   Update to 0.3.2.
>   
>   PR:		ports/178226
>   Submitted by:	Herbert J. Skuhra <h.skuhra@gmail.com> (maintainer)
> 
> Modified:
>   head/multimedia/gst123/Makefile
>   head/multimedia/gst123/distinfo
> 
> Modified: head/multimedia/gst123/Makefile
> ==============================================================================
> --- head/multimedia/gst123/Makefile	Fri May  3 21:35:23 2013	(r317265)
> +++ head/multimedia/gst123/Makefile	Fri May  3 21:36:29 2013	(r317266)
> @@ -1,13 +1,8 @@
> -# New ports collection makefile for:	gst123
> -# Date created:				Wed December 8, 2010
> -# Whom:					Herbert J. Skuhra <h.skuhra@gmail.com>
> -#
> +# Created by: Herbert J. Skuhra <h.skuhra@gmail.com>
>  # $FreeBSD$
> -#
>  
>  PORTNAME=	gst123
> -PORTVERSION=	0.2.1
> -PORTREVISION=	1
> +PORTVERSION=	0.3.2
>  CATEGORIES=	multimedia
>  MASTER_SITES=	http://space.twc.de/~stefan/gst123/
>  
> @@ -20,13 +15,24 @@ GNU_CONFIGURE=	yes
>  USE_GMAKE=	yes
>  USE_BZIP2=	yes
>  USE_GNOME=	gtk20
> -USE_GSTREAMER=	good
>  CONFIGURE_ENV=	NCURSES5_CONFIG=/usr/bin/true
>  LDFLAGS+=	-lncurses
>  
>  PLIST_FILES=	bin/${PORTNAME}
>  MAN1=		${PORTNAME}.1
>  
> +OPTIONS_DEFINE=	GSTREAMER1
> +
> +GSTREAMER1_DESC=	Multimedia support via GStreamer 1.0 (instead of 0.10)
> +
> +.include <bsd.port.options.mk>
> +
> +.if ${PORT_OPTIONS:MGSTREAMER1} || exists(${LOCALBASE}/libdata/pkgconfig/gstreamer-1.0.pc)
> +USE_GSTREAMER1=	good
> +.else
> +USE_GSTREAMER=	good
> +.endif

Please avoid using 'exists($some_file)' for determining dependencies.
If there's no way to force building without gstreamer1 the option should be
removed in favour of hard dependence on gstreamer1.

Max