From owner-cvs-all  Sun Dec 30  2: 2:27 2001
Delivered-To: cvs-all@freebsd.org
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7189037B416; Sun, 30 Dec 2001 02:02:22 -0800 (PST)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.11.6/8.11.6) with ESMTP id fBUA0GV21053;
	Sun, 30 Dec 2001 11:00:17 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Greg Lehey <grog@FreeBSD.org>
Cc: Julian Elischer <julian@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/share/man/man3 queue.3 
In-Reply-To: Your message of "Sun, 30 Dec 2001 09:49:36 +1030."
             <20011230094936.K90696@monorchid.lemis.com> 
Date: Sun, 30 Dec 2001 11:00:16 +0100
Message-ID: <21051.1009706416@critter.freebsd.dk>
From: Poul-Henning Kamp <phk@critter.freebsd.dk>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

In message <20011230094936.K90696@monorchid.lemis.com>, Greg Lehey writes:
>On Saturday, 29 December 2001 at  8:55:05 +0100, Poul-Henning Kamp wrote:
>> In message <200112282200.fBSM0Rw61760@freefall.freebsd.org>, Julian Elischer wr
>> ites:
>>> julian      2001/12/28 14:00:27 PST
>>>
>>>  Modified files:
>>>    share/man/man3       queue.3
>>>  Log:
>>>  Document some behaviour I'm depending on.
>>>  (TAILQ_FOREACH leaves the variable NULL if there were no more to do)
>>
>> I don't like this.
>
>Do you have a reason for not liking it?

Yes, I don't like statements with weird sideeffects.  If julian
wants the sideeffect, he should not use a _FOREACH() macro to hide
the internals of the loop.

_FOREACH() is for the plain & simple traversal of a queue(3) stucture,
anything more should explicitly state intent.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message