From owner-svn-ports-all@FreeBSD.ORG Mon Jan 6 20:15:09 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1B5F2246 for ; Mon, 6 Jan 2014 20:15:09 +0000 (UTC) Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DDE9C1650 for ; Mon, 6 Jan 2014 20:15:08 +0000 (UTC) Received: by mail-pd0-f182.google.com with SMTP id v10so18727265pde.27 for ; Mon, 06 Jan 2014 12:15:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=73Yxt58MK3R8DhUCEt84VhH74uo8a0DnGcot2Ww/lDs=; b=TBs445BW+xRdgp8vh6XV6Gy0JKwLfCK4DJ+CzLBD9vJm+vF127eD9hYYrTDlt2sXm0 fdeNhMf8IR5fy5ybNtKoQUM4/Ki+j5bzORYHRPjnjFMbrbzenmJs1NvD9MxjWdAj/oOS wp+j9AckBPY2O7Kws2ffPgxX1lL6XAdMG+MnXHcryckFYB07nHM5GUP8DA5lzbx+HYQH tRaUa498J3GSyJpZLZYc6jZ1I8W4pClv+y0b2aPfMLNRpoK8PKyy4+OpYGvGN4JxL3rR mFHlO5o0O3MKrqnBfNHJk5aoh8IGrTwwZsJ/hqmMWe3pttAOxxmGmJ5H6NTvljFLGbGd wWvw== X-Gm-Message-State: ALoCoQmQVx8DLmuRFp5TRzocLTLplOI5dy7F5N/4HNOUAOzElrjqwkGC2AjngP7+RyOQDyeKanJd MIME-Version: 1.0 X-Received: by 10.66.132.69 with SMTP id os5mr389799pab.114.1389039301755; Mon, 06 Jan 2014 12:15:01 -0800 (PST) Sender: bsd-src@helfman.org Received: by 10.70.78.130 with HTTP; Mon, 6 Jan 2014 12:15:01 -0800 (PST) In-Reply-To: <646831BE6E0393D4F36AB5CC@ogg.in.absolight.net> References: <201401051721.s05HLNPn088802@svn.freebsd.org> <201401051728.s05HSamN089750@svn.freebsd.org> <646831BE6E0393D4F36AB5CC@ogg.in.absolight.net> Date: Mon, 6 Jan 2014 12:15:01 -0800 X-Google-Sender-Auth: RgDR5hhUOlana4LRN50Prz7GqeI Message-ID: Subject: Re: svn commit: r338802 - in head/textproc: docbook-241 docbook-300 docbook-310 docbook-400 docbook-410 docbook-440 docbook-450 docbook-500 docbook-xml-450 From: Jason Helfman To: Mathieu Arnold Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Jason Helfman , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jan 2014 20:15:09 -0000 On Mon, Jan 6, 2014 at 6:22 AM, Mathieu Arnold wrote: > +--On 5 janvier 2014 17:21:23 +0000 Jason Helfman wrote: > | Log: > | - fix pkgname collisions > | -LATEST_LINK= docbook-241 > | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//} > | -LATEST_LINK= docbook-300 > | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//} > | -LATEST_LINK= docbook-310 > | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//} > | -LATEST_LINK= docbook-400 > | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//} > | -LATEST_LINK= docbook-410 > | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//} > | -LATEST_LINK= ${PORTNAME}-440 > | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//} > | -LATEST_LINK= ${PORTNAME}-450 > | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//} > | -LATEST_LINK= ${PORTNAME}-500 > | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//} > > Why the overly complicated computation where you could just have put the > number that was in the LATEST_LINK right away ? > Those ports version will never change, so it's not likely that anyone will > ever have to update the PKGNAMESUFFIX. > To me, this seems to be a style issue. If there is a problem with this, then please send a patch for approval to gabor@ > | -LATEST_LINK= ${PORTNAME}-450 > | +PKGNAMESUFFIX= ${PORTVERSION:S/.//} > | -LATEST_LINK= ${PORTNAME}-440 > | +PKGNAMESUFFIX= ${PORTVERSION:S/.//} > > And there, why the change of heart ? Now, we have a package named > docbook440 and one named docbook-xml44, which is rather not consistent at > all. > > I based these off of the PORTVERSION, rather than the ORIGIN, and didn't see an issue. I also wasn't comparing it to docbook pkgnames, but was comparing it with docbook-xml pkgnames. Beyond this, the maintainer approved the patches that has both docbook and docbook-xml ports. -jgh Regards, > > -- > Mathieu Arnold > > -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve