From owner-freebsd-wireless@FreeBSD.ORG Fri Oct 25 20:14:40 2013 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 79DF9296; Fri, 25 Oct 2013 20:14:40 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qe0-x22c.google.com (mail-qe0-x22c.google.com [IPv6:2607:f8b0:400d:c02::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 287142E98; Fri, 25 Oct 2013 20:14:40 +0000 (UTC) Received: by mail-qe0-f44.google.com with SMTP id 6so2683211qeb.31 for ; Fri, 25 Oct 2013 13:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=WvCwXmhBqUwILiG33CQkCmVfY7S0OEf/prND3kmo6cM=; b=mfJQA3+ztHpoVhizrzVzU0duMy9aS+CfPj/m9TTYFmy/H6UkDGHBruWc4E91MaKf7e y8YDJ+4RQQaST/8GS55jklE7PAOznTHyQSvNPy2eR5D4nfJK0N78vF0wpCZptlhWlinY DuZVaTHjHZ+02giKqmlMAlSb73JNuX7ZYHxCCdUOFbHRNe5otuFurWYtqHbJ9c66wY/G 3rXkeFcaMrt9u7luXE+Gh0FJtijyhT+GjsCQequHEwUrEIj2kf9jtvRHexnKKHCXUXsl mFMsCWXHKdnw3B14Prl3nWAEHVv3Rgcp2W1i01+iPk34EAbAoEbomN3OUy45FmKseGkn xHng== MIME-Version: 1.0 X-Received: by 10.49.103.161 with SMTP id fx1mr13256052qeb.68.1382732079409; Fri, 25 Oct 2013 13:14:39 -0700 (PDT) Received: by 10.224.207.66 with HTTP; Fri, 25 Oct 2013 13:14:39 -0700 (PDT) In-Reply-To: <1382662196.2498.1.camel@localhost> References: <1382662196.2498.1.camel@localhost> Date: Fri, 25 Oct 2013 13:14:39 -0700 Message-ID: Subject: Re: [iwn] request to test: linkq, plcp, txrate fixes From: Adrian Chadd To: Sean Bruno Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "freebsd-wireless@freebsd.org" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Oct 2013 20:14:40 -0000 Just committed it to -HEAD. -adrian On 24 October 2013 17:49, Sean Bruno wrote: > On Thu, 2013-10-24 at 13:04 -0700, Adrian Chadd wrote: > > Hi! > > > > I have a patch against iwn(4): > > > > > http://people.freebsd.org/~adrian/ath/20131024-iwn-1-fix-xmit-rate-plcp-linkq.diff > > > > This does a few things: > > > > * The multi-rate retry ("link quality" stuff) on iwn is a table, and I > > think I broke it slightly when I implemented 11n rate control. This > > disables it for now, at least until I / someone implements a replacement > > table setup and linkq decision. > > > > * get rid of the rate index stuff - it was used to decide a few things > and > > it was doing legacy-only rate index lookups. I've just removed it; it's > not > > needed. > > > > * Teach the raw transmit path to use the new plcp lookup routine that > sets > > things up. > > > > * Correctly implement 11g protection. Right now it was a bit of a hack > and > > it was not correct for 11a or 11n operation. > > > > I still get transmit hangs on my 4965 but the "invalid rate" failures > have > > disappeared. But for some odd reason, the transmits completed but weren't > > being marked as failed. I don't yet know why. > > > > I'm also not sure why transmit is hanging; sometimes it looks like DMA > > stalls somehow. > > > > So - maybe this'll help with various 11n issues on iwn(4), maybe it > won't. > > I'm not sure yet. I'm trying to avoid taking ownership of iwn(4) but I > > rather dislike the occasional 5100/4965 hangs.. > > > > Thanks, > > > > > > > > -adrian > > running this now against 11-CURRENT. No issues noted on my adapter > (Centrino Advanced-N 6205 [Taylor Peak]). All seems very good. > > I haven't tried it the office though, and that's the one that's the most > interesting I fear. > > sean >