From owner-svn-ports-all@FreeBSD.ORG Wed Jan 15 14:25:14 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D1CF1D42; Wed, 15 Jan 2014 14:25:14 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A67641816; Wed, 15 Jan 2014 14:25:14 +0000 (UTC) Received: from [192.168.0.21] (unknown [130.255.19.191]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id C769C435C7; Wed, 15 Jan 2014 08:24:56 -0600 (CST) Message-ID: <52D69A31.9070801@marino.st> Date: Wed, 15 Jan 2014 15:24:49 +0100 From: John Marino User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Mathieu Arnold Subject: Re: svn commit: r339777 - head/lang/modula3 References: <201401151341.s0FDfQ1M053094@svn.freebsd.org> <998760DE607B43BBDEA3C8AE@ogg.in.absolight.net> In-Reply-To: <998760DE607B43BBDEA3C8AE@ogg.in.absolight.net> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: marino@freebsd.org List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jan 2014 14:25:14 -0000 On 1/15/2014 15:17, Mathieu Arnold wrote: > +--On 15 janvier 2014 13:41:26 +0000 John Marino wrote: > | lang/modula3: Not for FreeBSD 8.x > | > | +. if !exists(/usr/include/xlocale/_ctype.h) > | +IGNORE= the bootstrap compiler only runs on FreeBSD 9.0 or later > | +. endif > | . endif > > That should be .if ${OSVERSION} < 9000000 or something. > I disagree. OSVERSION should be discouraged, and detection used instead. OSVERSION should only be used as a last resort. Once Modula3 builds on DragonFly, I'll probably make this IGNORE valid for both systems in which case OSVERSION is completely inappropriate. How OSVERSION is to be handled has been an ongoing discussion with portmgr, so I'm hoping the new blood there can help come up with a sensible policy to define when this platform-dependent variable can and shouldn't be used. John