From nobody Thu Sep 18 10:13:42 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cSBLG6MDlz687R6; Thu, 18 Sep 2025 10:13:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cSBLG4VBPz474C; Thu, 18 Sep 2025 10:13:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758190422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TrmAXJ6f1yFkPO/CoxXSJBvMEWdQlyPqDReVq2wwa+k=; b=vuD7q/h6zZ+QvWaRE4AZH9bNZ/kIN7qfldUS+V5y4pZuvZuZr3ofLA5Jrygtil4EWVzIkG zFlrEzIkx/taJ16aPqrb+Vc651Wxc/Wvt1/MMRSGWtIluvzf6te+n3fOrYqG+rdZ6AGVsu LPA5ViOD8VArBiN+H8Fw5vJCXwTBOT10RsBFg5Xis0s6s7mCoOed1vu75RI0YN83m/IMu9 2/VxaLgR0/vYNdwH+wuUQHvlvQfoSjsKNqy9XjBExgOFsrphfGd/D7qfwKG7ZjrGrE1Rud Y80nIJCkzgi3223QJxYN1VIopHGB1qu6ZzaltH6erQcNpTc4F9YpC80cLlsEfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758190422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TrmAXJ6f1yFkPO/CoxXSJBvMEWdQlyPqDReVq2wwa+k=; b=pc15kX+tc/y2pJSFu9bG2h1LiKCbhg93Ifc+GAiEcK/+cj1reAP5KM2uDnGr6TECrhvaPF PsiCdhnsuVPWpd10K50IKKZxYqiqkhKQrP2EEAoNQyDOum9Q7UC/9x3eykRc087rr+7Lkp vSkm5/kuUGGWyj+km0ELwcxQUWM5uaWOAttxcUpcdfsS/0EA+K6noOZ9+7eOaReYr2TWOt 94mEthqR63v6/dP+7LYZ1yxtn2CBb9rB3RwRQeCHLwJ51T+hHq96WKlHXbWNZcyLd+kvOz oOdrFlr8y6mDBnMRqaOqpik0ZJPZlHztzbld1lopGYFl+FF+r4/MzSdgnLtN0Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758190422; a=rsa-sha256; cv=none; b=IDdpeGpBxnyZ5LYYjVmSZ4FjkmeAnuz1MHKKIozwyfo+kXs0GzzugTTdN87Rlzx+DIgI9k ZVYCVg/VRkhSApCNrC5vpR1c7iuC5O/tdMgmd6AA6/6BcilT2vYnlrFYdoJjKFsTQu5Zi1 psPl/oRA5C0XGUjnFRcBb+4mipPSUgJL6gGph6ZRdlg+r5Y6d+6sgoDN+0JQdj6mf3+vfC SMgu4npT/cloy+unRqueNwePkNU1Kxx6BHDBhOph27GM6gkDD3COtkSlDhK+8t6UzZLiSo wA9LDUn7CFNlKYc6CiJRw/pTkCezuVvUsfiDyIBNDFXddgCs/y0BN6TMSwyI+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cSBLG3rSjz16Yw; Thu, 18 Sep 2025 10:13:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58IADgWg072674; Thu, 18 Sep 2025 10:13:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58IADgxe072671; Thu, 18 Sep 2025 10:13:42 GMT (envelope-from git) Date: Thu, 18 Sep 2025 10:13:42 GMT Message-Id: <202509181013.58IADgxe072671@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 009268dbfdd5 - stable/14 - hwpmc: On attach, fix allowing a PMC's owner to attach it to itself List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 009268dbfdd5fe487117654f75ae3850a2c1a7d9 Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=009268dbfdd5fe487117654f75ae3850a2c1a7d9 commit 009268dbfdd5fe487117654f75ae3850a2c1a7d9 Author: Olivier Certner AuthorDate: 2025-09-09 12:48:05 +0000 Commit: Olivier Certner CommitDate: 2025-09-18 10:13:10 +0000 hwpmc: On attach, fix allowing a PMC's owner to attach it to itself The returned value in this case was wrong, and would basically prevent some PMC's owner process to attach that PMC to itself although the security checks underneath would have allowed it. Now that this early return has been fixed, its block basically becomes a performance short-circuit which has no effect from a functional standpoint. Fixes: ebccf1e3a6b1 ("Bring a working snapshot of hwpmc(4), ...") MFC after: 9 days Sponsored by: The FreeBSD Foundation (cherry picked from commit 1c40b15971f09c0c0676ae476b88b32166eae8ac) --- sys/dev/hwpmc/hwpmc_mod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/hwpmc/hwpmc_mod.c b/sys/dev/hwpmc/hwpmc_mod.c index 21f416510d5e..54fcc2dafb4f 100644 --- a/sys/dev/hwpmc/hwpmc_mod.c +++ b/sys/dev/hwpmc/hwpmc_mod.c @@ -1042,7 +1042,7 @@ pmc_can_attach(struct pmc *pm, struct proc *t) */ if ((o = pm->pm_owner->po_owner) == t) - return (false); + return (true); PROC_LOCK(o); oc = o->p_ucred;