From owner-freebsd-ports@FreeBSD.ORG Tue Aug 4 06:07:40 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2951D106564A for ; Tue, 4 Aug 2009 06:07:40 +0000 (UTC) (envelope-from mel.flynn+fbsd.ports@mailing.thruhere.net) Received: from mailhub.rachie.is-a-geek.net (rachie.is-a-geek.net [66.230.99.27]) by mx1.freebsd.org (Postfix) with ESMTP id E85EB8FC1A for ; Tue, 4 Aug 2009 06:07:39 +0000 (UTC) (envelope-from mel.flynn+fbsd.ports@mailing.thruhere.net) Received: from smoochies.rachie.is-a-geek.net (mailhub.rachie.is-a-geek.net [192.168.2.11]) by mailhub.rachie.is-a-geek.net (Postfix) with ESMTP id F1F797E818; Mon, 3 Aug 2009 22:07:38 -0800 (AKDT) From: Mel Flynn To: freebsd-ports@freebsd.org Date: Mon, 3 Aug 2009 22:07:37 -0800 User-Agent: KMail/1.11.4 (FreeBSD/8.0-BETA2; KDE/4.2.4; i386; ; ) References: <4A74D10A.9000507@uffner.com> <200908031312.14400.mel.flynn+fbsd.ports@mailing.thruhere.net> <4A77A67D.1050101@uffner.com> In-Reply-To: <4A77A67D.1050101@uffner.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200908032207.37816.mel.flynn+fbsd.ports@mailing.thruhere.net> Cc: Tom Uffner Subject: Re: x11-toolkits/xview requires COMPAT_43TTY defined to build on -CURRENT X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2009 06:07:40 -0000 On Monday 03 August 2009 19:09:49 Tom Uffner wrote: > Mel Flynn wrote: > > On Saturday 01 August 2009 15:34:34 Tom Uffner wrote: > >> x11-toolkits/xview requires COMPAT_43TTY defined to build on -CURRENT > > > > In your kernel config. > > no. it was in my kernel config. my problem was that the port would not > compile w/o the definition in the port makefiles. Right, my bad, did my testing on a 7.x machine with my brain screwed on wrong. Anyway, interesting reading in the svn log: r191919 | ed | 2009-05-08 12:06:37 -0800 (Fri, 08 May 2009) | 9 lines Burn TTY ioctl bridges in compat layers. I really don't want any pieces of code to include ioctl_compat.h, so let the ibcs2 and svr4 compat leave sgtty alone. If they want to support sgtty, they should emulate it on top of termios, not sgtty. The code has been marked with BURN_BRIDGES for a long time. ibcs2 and svr4 are not really popular pieces of code anyway. --------------------------------------------------------- So, the real fix should come from upstream. For the time being, this should work, marked MAKE_JOBS_UNSAFE while I was in there. The OSVERSION leaves a three week hole where things won't work, but that should be acceptable. --- x11-toolkits/xview/Makefile.orig 2009-08-03 21:38:34.000000000 -0800 +++ x11-toolkits/xview/Makefile 2009-08-03 22:05:39.000000000 -0800 @@ -32,12 +32,16 @@ SUB_FILES= pkg-message MAN1= xview.1 +MAKE_JOBS_UNSAFE= yes X11BASE2FIX= clients/olwmslave/help_file.c lib/libxview/help/help_file.c \ lib/libxview/misc/gettext.h lib/libxview/textsw/txt_e_menu.c .include +.if ${OSVERSION} > 800089 +CFLAGS+= -DCOMPAT_43TTY +.endif pre-configure: @${REINPLACE_CMD} -e 's+/usr/local+${PREFIX}+;' \ ${WRKSRC}/config/XView.cf -- Mel