From owner-svn-ports-head@freebsd.org Thu Feb 8 09:16:38 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EB4CEF11BD1; Thu, 8 Feb 2018 09:16:37 +0000 (UTC) (envelope-from ganael.laplanche@centralesupelec.fr) Received: from smtp2.supelec.fr (smtp2.supelec.fr [160.228.120.31]) by mx1.freebsd.org (Postfix) with ESMTP id 2E20E7C8C9; Thu, 8 Feb 2018 09:16:37 +0000 (UTC) (envelope-from ganael.laplanche@centralesupelec.fr) Received: from localhost (localhost [127.0.0.1]) by smtp2.supelec.fr (Postfix) with ESMTP id 9F91A80ABA; Thu, 8 Feb 2018 10:10:18 +0100 (CET) X-Virus-Scanned: amavisd-new at smtp2.supelec.fr Received: from smtp2.supelec.fr ([127.0.0.1]) by localhost (smtp2.supelec.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ACPWOWaaawtc; Thu, 8 Feb 2018 10:10:18 +0100 (CET) Received: from dmc12.centralesupelec.fr (unknown [172.16.6.210]) by smtp2.supelec.fr (Postfix) with ESMTPSA id 31B7280863; Thu, 8 Feb 2018 10:10:18 +0100 (CET) From: Ganael Laplanche To: Baptiste Daroussin Cc: Mark Linimon , Alexey Dokuchaev , Ganael LAPLANCHE , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r460940 - in head/games: afternoonstalker burgerspace cosmosmash Date: Thu, 08 Feb 2018 10:10:17 +0100 Message-ID: <2650675.ed8esFDKD5@dmc12.centralesupelec.fr> Organization: CentraleSupelec User-Agent: KMail/4.14.10 (FreeBSD/11.1-RELEASE-p4; KDE/4.14.30; amd64; ; ) In-Reply-To: <20180208083213.yzrjhl4lwuqykvpg@ivaldir.net> References: <201802041634.w14GYHVW017651@repo.freebsd.org> <20180208071931.GA13039@lonesome.com> <20180208083213.yzrjhl4lwuqykvpg@ivaldir.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 09:16:38 -0000 On Thursday 08 February 2018 09:32:13 Baptiste Daroussin wrote: Hi everyone, > > > ... by forcing gnu++98 without giving the details of the breakages and > > > why they were not properly fixed instead. :-) > > > > For once I'm going to agree with danfe (someone take a picture!) but only > > to the extent that I would like to ask that the commit messages be "work > > around the build" rather than "fix". There have been numerous commits > > that did contain actual code fixes. I should probably have written a more detailed commit msg, sorry. > My point here, is variations between c++ standards may make some code > incompatible and sometime the version of the standard may/should be > specified, because the code is clearly C++98. > > In clang 6 when you build c++ instead of defaulting of c++98 like it used to > be is now defaulting on c++14 meaning all the code whihch expected c++98 as > default standard are now broken and the -std flag should be supplied. The > same happened when the C compilers switched from C89 to C99 as default > standard. On 143 ports we needed to make that change. > > Being compatible with newer c++ standard is an upstream decision to take, > not hours. The compilers are able to specify the standard you are using, > imho it is normal and expected for maintainers to use that feature :) I agree with Bapt, if a project is written in C++ 98, that is not the porter's job to re-write it into a newer standard, that's why specifying c++98 for those ports made sense to me. Moreover, those games have not seen updates for years now, so there may be not point in updating their code standard. Best regards, -- Ganael Laplanche Unix Systems Engineer @CentraleSupelec Rennes