Date: Fri, 29 Jun 2012 13:51:52 -0400 From: George Neville-Neil <gnn@neville-neil.com> To: Andriy Gapon <avg@freebsd.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r237748 - in head/sys/cddl/dev/dtrace: amd64 i386 Message-ID: <D4E7736B-0F58-444F-AA1B-B7B8FAA1A875@neville-neil.com> In-Reply-To: <4FED5C51.9060603@FreeBSD.org> References: <201206290735.q5T7ZbSk026312@svn.freebsd.org> <4FED5C51.9060603@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 29, 2012, at 03:42 , Andriy Gapon wrote: > on 29/06/2012 10:35 Andriy Gapon said the following: >> Author: avg >> Date: Fri Jun 29 07:35:37 2012 >> New Revision: 237748 >> URL: http://svn.freebsd.org/changeset/base/237748 >>=20 >> Log: >> dtrace instruction decoder: add 0x0f 0x1f NOP opcode support >>=20 >> According to the AMD manual the whole range from 0x09 to 0x1f are = NOPs. >> Intel manual mentions only 0x1f. Use only Intel one for now, it = seems >> to be the one actually generated by compilers. >> Use gdb mnemonic for the operation: "nopw". >=20 > BTW, here I have a patch that brings our copy of dtrace dis_tables.c = to the > latest version available in OpenSolaris code: > http://people.freebsd.org/~avg/dtrace-disassm-osol.diff >=20 > I haven't studied at all what the newer code brings in, but it must be = some > fixes and improvements, I guess :-) > The change is mostly a mechanical merge, plus some changes on top to = get the > code to compile. > I've been using the code for a few weeks and haven't run into any = problems. >=20 > Should I put this change into the tree? Have you tried running the DTrace test suite on it? We have the suite = in the tree. If the suite passes similarly with and without the patch I'd say just = put it in and we'll go from there. It's quite a large patch, but, yes, much of it is mechanical changes. Best, George
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D4E7736B-0F58-444F-AA1B-B7B8FAA1A875>