Date: Fri, 30 Nov 2012 08:32:08 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: Robert Watson <rwatson@FreeBSD.org>, freebsd-arch@FreeBSD.org Subject: Re: Print a (rate-limited) warning when UMA zone is full. Message-ID: <20121130073208.GA1409@garage.freebsd.pl> In-Reply-To: <20121130084954.Q1018@besplex.bde.org> References: <20121129090147.GB1370@garage.freebsd.pl> <alpine.BSF.2.00.1211291027430.59662@fledge.watson.org> <20121130084954.Q1018@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 30, 2012 at 09:53:41AM +1100, Bruce Evans wrote: > >> When UMA zone is created, one can add configure a warning that should = be=20 > >> printed when UMA zone is full by calling: > >>=20 > >> uma_zone_set_warning(socket_zone, > >> "kern.ipc.maxsockets limit exceeded, please see tuning(7)."); >=20 > Please don't clone messages of this form. It has bad grammar, bad > style and a garbage pointer. Many of these were cloned from previous > messages of this form. >=20 > Bad grammar: > 1. Redundant "limit". kern.ipc.maxsockets is already a limit. I don't think I can agree here. kern.ipc.maxsockets is not only a limit - it is a string, a sysctl, a tunable... being specific that we are talking about kern.ipc.maxsockets limit is a good thing, IMHO. > 2. Wrong object. The thing not being exceeded is the number of sockets, > not the limit on the number of sockets. > 3. Wrong verb. It is impossible to exceed an enforcible, enforced limit > This seems hard to fix without making the message too verbose. A full > description would say something to the effect that that the limit wou= ld > be exeeded if exceeding it were possible and permitted. Or some > conventional wording for this situation could be used. The above has > conventional wording, but has too many errors for me. I agree 'exceeded' is wrong word here, I copied the message from kern.maxfiles warning, but really the messages in the patch were just examples how the new function can be used. How about this: The kern.ipc.maxsockets limit has be reached. The message is short. It tells what to tune. It gives sysctl name, so hopefully sysctl description will tell more about this limit. I'm not a native English speaker, so I'm open to other suggestions of course. > 6. termination with a ".'. Error messages are conventionally not termina= ted We probably won't reach an agreement here. In my opinion every sentence should be terminated with a period. Also it is a warning not an error message. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --2oS5YaxWCcQjTEyO Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlC4YPgACgkQForvXbEpPzRKHgCfTG+3HSRYhVqyrbfWBfjeeFPl RrkAn0Em9Y8QL41buqcrxtZ5o18r9ygo =v7LY -----END PGP SIGNATURE----- --2oS5YaxWCcQjTEyO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121130073208.GA1409>