From owner-p4-projects@FreeBSD.ORG Sat Sep 1 02:17:48 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5A48616A41B; Sat, 1 Sep 2007 02:17:48 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2FFAA16A418 for ; Sat, 1 Sep 2007 02:17:48 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1EEB213C469 for ; Sat, 1 Sep 2007 02:17:48 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l812HmLn038864 for ; Sat, 1 Sep 2007 02:17:48 GMT (envelope-from cnst@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l812HliK038861 for perforce@freebsd.org; Sat, 1 Sep 2007 02:17:47 GMT (envelope-from cnst@FreeBSD.org) Date: Sat, 1 Sep 2007 02:17:47 GMT Message-Id: <200709010217.l812HliK038861@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to cnst@FreeBSD.org using -f From: "Constantine A. Murenin" To: Perforce Change Reviews Cc: Subject: PERFORCE change 125919 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Sep 2007 02:17:48 -0000 http://perforce.freebsd.org/chv.cgi?CH=125919 Change 125919 by cnst@dale on 2007/09/01 02:17:08 KNF for set_T_dev_t() Affected files ... .. //depot/projects/soc2007/cnst-sensors/sbin.sysctl/sysctl.c#8 edit Differences ... ==== //depot/projects/soc2007/cnst-sensors/sbin.sysctl/sysctl.c#8 (text+ko) ==== @@ -561,17 +561,13 @@ static struct stat statb; if (strcmp(path, "none") && strcmp(path, "off")) { - int rc = stat(path, &statb); - if (rc) { + if (stat(path, &statb) != 0) err(1, "cannot stat %s", path); - } - if (!S_ISCHR(statb.st_mode)) { + if (!S_ISCHR(statb.st_mode)) errx(1, "must specify a device special file."); - } - } else { + } else statb.st_rdev = NODEV; - } *val = (void *) &statb.st_rdev; *size = sizeof(statb.st_rdev); }