From owner-freebsd-current@FreeBSD.ORG  Thu May 28 22:07:02 2015
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id BB760ECC;
 Thu, 28 May 2015 22:07:02 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: from mail-qg0-x236.google.com (mail-qg0-x236.google.com
 [IPv6:2607:f8b0:400d:c04::236])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 760E162F;
 Thu, 28 May 2015 22:07:02 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: by qgf2 with SMTP id 2so22545738qgf.3;
 Thu, 28 May 2015 15:07:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=9YrIfnVs4Y/F9T8Fp5dLZ1gkLtV9/mhvhZJEJG2fO6Y=;
 b=YVQIME/xdytRBoXfvv2MNeFV1WVFHqBILGFwZ1+HtGpQYerEIjg2hgjFpYyMq7D2R3
 G1M5uuXn9o3GQLs2V2evoDJw/Kg7MTNfofGaSV9XTQdHz6DGStXRFcYrYdxQ7Ta1AGyH
 aLsd0fozcxJ4kexAsOgIZBrGNd7vmbG8R5orHCcZ7FNACO31XKoX2PoqaqU0eH5ejJkZ
 +D+m5w1LMbUoOpmuxghxXxLeONcVSqMS5QCvZLnA/xUeLxUQx7E2gWJQs12OZ+F4G1rS
 YruzYpy4meMgaDPCm1Nobk4jBjz36O+Xop9DFJVSNeIKrJXoHVxdu40WM5FjClLUn2Dl
 ux0g==
MIME-Version: 1.0
X-Received: by 10.141.18.136 with SMTP id u130mr6129365qhd.54.1432850821608;
 Thu, 28 May 2015 15:07:01 -0700 (PDT)
Received: by 10.140.98.73 with HTTP; Thu, 28 May 2015 15:07:01 -0700 (PDT)
In-Reply-To: <20150528191806.GB70327@ivaldir.etoilebsd.net>
References: <CAG=rPVdLjmj8oOeqQQOLr6ShvU=2H3y0j5hg4q8UrB70rj3Xpg@mail.gmail.com>
 <55670C5A.6080500@FreeBSD.org>
 <CAG=rPVcfs4LB36L8ToOFkVad5t=CWb6wSOog=SfWT-8t-7tDwg@mail.gmail.com>
 <20150528191806.GB70327@ivaldir.etoilebsd.net>
Date: Thu, 28 May 2015 15:07:01 -0700
Message-ID: <CAGHfRMDpvpa0AnCegVDrpcW=3w6P+w-87UpP=8wZeXwQHZ7ccQ@mail.gmail.com>
Subject: Re: Need help reducing compilation warnings in CURRENT
From: NGie Cooper <yaneurabeya@gmail.com>
To: Baptiste Daroussin <bapt@freebsd.org>
Cc: Craig Rodrigues <rodrigc@freebsd.org>,
 Johannes Jost Meixner <xmj@freebsd.org>, 
 freebsd-current Current <freebsd-current@freebsd.org>, 
 "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 May 2015 22:07:02 -0000

On Thu, May 28, 2015 at 12:18 PM, Baptiste Daroussin <bapt@freebsd.org> wrote:
...
> If not upstreamed, there is a good chance it get lost during the next update. So
> in the special case of warning fixes, I would strongly advice to upstream
> first!!

+200

Plus upstream sources generally get slammed by multiple downstream
projects, so if we can contribute back fixes or pull in upstream fixes
as cherrypicks through the vendor tree, then that would reduce our
diff and make sure that upstream projects benefit from our changes.

The only time we should really be modifying and not giving back is
when we have FreeBSD-specific modifications that don't make sense in
upstream projects. Those should be rare occurrences though...

Thanks,
-NGie