From owner-freebsd-hackers@FreeBSD.ORG Thu Jan 15 06:59:47 2015 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 425E0509 for ; Thu, 15 Jan 2015 06:59:47 +0000 (UTC) Received: from mx1.scaleengine.net (beauharnois2.bhs1.scaleengine.net [142.4.218.15]) by mx1.freebsd.org (Postfix) with ESMTP id 02FD41A0 for ; Thu, 15 Jan 2015 06:59:46 +0000 (UTC) Received: from [192.168.1.2] (Seawolf.HML3.ScaleEngine.net [209.51.186.28]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 9CA07617AB for ; Thu, 15 Jan 2015 06:59:40 +0000 (UTC) Message-ID: <54B7656D.9000704@freebsd.org> Date: Thu, 15 Jan 2015 01:59:57 -0500 From: Allan Jude User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org Subject: Re: [PATCH] Display progress during getmemsize() so the kernel doesn't look like it hanged References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RUdiQ49dWmj5EqVT5SVT5fJPCNA76Lles" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2015 06:59:47 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RUdiQ49dWmj5EqVT5SVT5fJPCNA76Lles Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2015-01-15 01:54, Pokala, Ravi wrote: > -----Original Message----- >> Date: Tue, 13 Jan 2015 13:53:19 -0500 >> From: John Baldwin >> To: Eric van Gyzen , Lars Engels >> , Allan Jude >> Cc: freebsd-hackers@freebsd.org >> Subject: Re: [PATCH] Display progress during getmemsize() so the >> kernel doesn't look like it hanged >> Message-ID: <3221643.2Qu3vC2WD5@ralph.baldwin.cx> >> Content-Type: text/plain; charset=3D"us-ascii" >> >> On 1/13/15 10:48 AM, Eric van Gyzen wrote: >>> On 01/13/2015 04:11, Lars Engels wrote: >>>> On Mon, Jan 12, 2015 at 12:27:18AM -0500, Allan Jude wrote: >>>>> Is this feature still useful with memtest.tests=3D0? >>>> This feature is useful for everyone who has it set to 1, if they kno= w >>>> about it or not. So it's a very useful feature. >>> >>> Agreed. >>> >>> Comments on the patch: >>> >>> The patch will divide by zero when PAGE_SIZE > 1 MiB. Maybe remove >>> PAGES_PER_MB, and just use PAGES_PER_GB. Make it const, too. >>> >>> The "total" line is mostly redundant with the later messages regardin= g >>> "real memory" and "avail memory". I suggest removing it. >> >> I agree with these. One other nit is that FreeBSD tends to use all ca= ps >> for a macro rather than variables. Ravi, how about this variant, it >> also only displays the dots if the memory test is enabled. Also, I >> think the commit to disable the test should probably be merged to 10, = yes. >=20 > We have a winner. I regenerated the patch against 10-STABLE and attache= d > it to the PR. Thanks all! >=20 > -Ravi >=20 > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.o= rg" >=20 Glad to see this, thanks for doing the work Ravi. Also, I agree with jhb@, we should disable the test by default in stable/10 (i think it is off by default only for VMs currently). --=20 Allan Jude --RUdiQ49dWmj5EqVT5SVT5fJPCNA76Lles Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJUt2VwAAoJEJrBFpNRJZKfgXkP/AjxiYbrQHCdsC9cBxQCCgm3 ozxqkOhBg3A8Kc2HyCI00pXe2+sbJ7sPBUSy+eNuDhjj9zkQkOTZNe51qYyA3/cr GpVs9wuKa/goz45ExWR/aIt85wZdGMLCEwivvVNarxbbGccUQxI80obaGS7yKcn+ OHNM8uDxbAjibteABUfcapDaoXYL7Up14G+6MvZ3ImISIbJ8dddcd4PXwEPpfr83 Qwbmyf8HzPpCqG8OIq8jFm2fZMb9t0jl95cSul1UMX50a2l5lWBIlk8l6ccKR0yS 6898/MtYJNMEgv40KTJw7PZMC/ij0aLEIDpMgLQn8PzkF5EdqcpjNZZjVxO3Xnq8 ply/2QhuMuJb1DLPDF/gLJ2E9QIJcdHUpfQP9YDVFXl9SwM4Lu9R2PhAv5x5Zw+a /dA0CJvPdQW6PacJuU/ne1b9UF2vZdv5lFJXm4j7YyTTAF7bpOBbWdeMsxQf/8FI LpEeO6F5ggPNTsVPvEwzaCdcPycM9ateNsRuGogP5/FZoExOFCLSg8987Gbq+qZd peDnkqmd0xuIbtICdKX/o1prruTJhkaktDuS/VbaGsccut+1kVvbyBZ+g7wVpXG5 WoCjvSpYfAxu9fzyyLUPfriVZdvP7PlaJvCM12aIxl9jP/afnx8KolaWkAoXVj83 HJkLTm1wLN6Rl4ZYMcjm =XFqR -----END PGP SIGNATURE----- --RUdiQ49dWmj5EqVT5SVT5fJPCNA76Lles--