From owner-dev-commits-src-all@freebsd.org Sun Jan 17 00:57:58 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 326CE4D2729; Sun, 17 Jan 2021 00:57:58 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DJGjx5NKKz3PNy; Sun, 17 Jan 2021 00:57:57 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.229.168]) by shaw.ca with ESMTPA id 0wO9leFqvbYg30wOAlHpKv; Sat, 16 Jan 2021 17:57:55 -0700 X-Authority-Analysis: v=2.4 cv=Q4RsX66a c=1 sm=1 tr=0 ts=60038b93 a=7AlCcx2GqMg+lh9P3BclKA==:117 a=7AlCcx2GqMg+lh9P3BclKA==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=EmqxpYm9HcoA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=VNurUuPmW1-XxwhfVT0A:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id 98CDD801; Sat, 16 Jan 2021 16:57:52 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 10H0vqp6056258; Sat, 16 Jan 2021 16:57:52 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202101170057.10H0vqp6056258@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Mariusz Zaborski cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: b7ab6832cd98 - main - cat: disable building it with Casper In-reply-to: <202101170021.10H0LZEk066670@gitrepo.freebsd.org> References: <202101170021.10H0LZEk066670@gitrepo.freebsd.org> Comments: In-reply-to Mariusz Zaborski message dated "Sun, 17 Jan 2021 00:21:35 +0000." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 16 Jan 2021 16:57:52 -0800 X-CMAE-Envelope: MS4xfJfgB0JJaKFBYWvbyKeYpfBqOI4g79BMDc6Fa2PoLakcUfhd/g8w15N1l3gKOALjJVrFvlAfVRFlxPtEfFWK9HG0LZT+HNO95Jaj9vbwQk0CQOwQwgnB L1F9qTHpv5I3g60KwtybmZd6STDXgr1FAii4P4AEhsjQq3PXTbgIQPlqa9Qu/tN45ZumGV4xpQV+vjLPNaWm+F1HfyoPcbJU61RCf032ucJL6lEarETQCzMV 4sKiRBwCrKYTpo+O5xFGxWX6RWjPWF2t8edChiJysisOLeWTiWInQ+HJiqax1NXpmGIdvMwe4ZMXlzoDTconDWY1PJHvK+YWXWcmTwLfE68= X-Rspamd-Queue-Id: 4DJGjx5NKKz3PNy X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jan 2021 00:57:58 -0000 In message <202101170021.10H0LZEk066670@gitrepo.freebsd.org>, Mariusz Zaborski writes: > The branch main has been updated by oshogbo: > > URL: https://cgit.FreeBSD.org/src/commit/?id=b7ab6832cd988aff7f4e468e507c314d > d7641638 > > commit b7ab6832cd988aff7f4e468e507c314dd7641638 > Author: Mariusz Zaborski > AuthorDate: 2021-01-17 00:04:28 +0000 > Commit: Mariusz Zaborski > CommitDate: 2021-01-17 00:21:46 +0000 > > cat: disable building it with Casper > > We want to measure what are the actual cost of sandboxing cat(1). > > Requested by: mjg, cy, Mike Karels > Discussed with: rwatson, markj > --- > bin/cat/Makefile | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/bin/cat/Makefile b/bin/cat/Makefile > index abfdcbcfbb2e..cce69d8aad9e 100644 > --- a/bin/cat/Makefile > +++ b/bin/cat/Makefile > @@ -15,11 +15,12 @@ CFLAGS+=-DBOOTSTRAP_CAT > HAS_TESTS= > SUBDIR.${MK_TESTS}+= tests > > -.if ${MK_CASPER} != "no" && !defined(RESCUE) && !defined(BOOTSTRAPPING) > -LIBADD+= casper > -LIBADD+= cap_fileargs > -LIBADD+= cap_net > -CFLAGS+=-DWITH_CASPER > -.endif > +# Temporary disable building cat with Casper. > +#.if ${MK_CASPER} != "no" && !defined(RESCUE) && !defined(BOOTSTRAPPING) > +#LIBADD+= casper > +#LIBADD+= cap_fileargs > +#LIBADD+= cap_net > +#CFLAGS+=-DWITH_CASPER > +#.endif > > .include > Hi, Almost there. ld: error: undefined symbol: cap_init >>> referenced by cat.c:154 (/opt/src/git-src/bin/cat/cat.c:154) >>> cat.o:(main) ld: error: undefined symbol: fileargs_cinit >>> referenced by cat.c:158 (/opt/src/git-src/bin/cat/cat.c:158) >>> cat.o:(main) ld: error: undefined symbol: cap_service_open >>> referenced by cat.c:131 (/opt/src/git-src/bin/cat/cat.c:131) >>> cat.o:(main) ld: error: undefined symbol: cap_net_limit_init >>> referenced by cat.c:135 (/opt/src/git-src/bin/cat/cat.c:135) >>> cat.o:(main) ld: error: undefined symbol: cap_net_limit_name2addr_family >>> referenced by cat.c:141 (/opt/src/git-src/bin/cat/cat.c:141) >>> cat.o:(main) --- all_subdir_kerberos5 --- --- libheimntlm.so.11.debug --- objcopy --only-keep-debug libheimntlm.so.11.full libheimntlm.so.11.debug --- libheimntlm.so.11 --- objcopy --strip-debug --add-gnu-debuglink=libheimntlm.so.11.debug libheimntlm.so.11.full libheimntlm.so.11 --- all_subdir_lib --- --- init_test --- (cd /opt/src/git-src/lib/csu/tests/dynamic && DEPENDFILE=.depend.init_test NO_SUBDIR=1 make -f /opt/src/git-src/lib/csu/tests/dynamic/Makefile _RECURSING_PROGS=t PROG=init_test ) --- all_subdir_bin --- ld: error: undefined symbol: cap_net_limit >>> referenced by cat.c:143 (/opt/src/git-src/bin/cat/cat.c:143) >>> cat.o:(main) ld: error: undefined symbol: cap_close >>> referenced by cat.c:168 (/opt/src/git-src/bin/cat/cat.c:168) >>> cat.o:(main) ld: error: undefined symbol: fileargs_open >>> referenced by cat.c:263 (/opt/src/git-src/bin/cat/cat.c:263) >>> cat.o:(scanfiles) ld: error: undefined symbol: fileargs_realpath >>> referenced by cat.c:441 (/opt/src/git-src/bin/cat/cat.c:441) >>> cat.o:(scanfiles) ld: error: undefined symbol: cap_getaddrinfo >>> referenced by cat.c:444 (/opt/src/git-src/bin/cat/cat.c:444) >>> cat.o:(scanfiles) ld: error: undefined symbol: cap_connect >>> referenced by cat.c:468 (/opt/src/git-src/bin/cat/cat.c:468) >>> cat.o:(scanfiles) cc: error: linker command failed with exit code 1 (use -v to see invocation) *** [cat.full] Error code 1 make[4]: stopped in /opt/src/git-src/bin/cat make[1]: stopped in /opt/src/git-src make: stopped in /opt/src/git-src exiting RC=2: building amd64 -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.