From owner-svn-ports-head@freebsd.org Wed Mar 29 19:57:24 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 384C4D24D04 for ; Wed, 29 Mar 2017 19:57:24 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 070F226E for ; Wed, 29 Mar 2017 19:57:23 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: ec655063-14b9-11e7-bfb5-0d159cd3c324 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id ec655063-14b9-11e7-bfb5-0d159cd3c324; Wed, 29 Mar 2017 19:57:23 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v2TJvFFb001935; Wed, 29 Mar 2017 13:57:15 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1490817435.64669.5.camel@freebsd.org> Subject: Re: svn commit: r437089 - in head/devel: . hhdate hhdate/files From: Ian Lepore To: Alexey Dokuchaev , Mark Linimon Cc: Michael Gmelin , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Date: Wed, 29 Mar 2017 13:57:15 -0600 In-Reply-To: <20170329171930.GA96917@FreeBSD.org> References: <201703272235.v2RMZKfx024323@repo.freebsd.org> <20170328142701.GA20879@FreeBSD.org> <20170328165708.3feecd6a@bsd64.grem.de> <20170329020527.GA8185@lonesome.com> <20170329171930.GA96917@FreeBSD.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 19:57:24 -0000 On Wed, 2017-03-29 at 17:19 +0000, Alexey Dokuchaev wrote: > On Tue, Mar 28, 2017 at 09:05:27PM -0500, Mark Linimon wrote: > > > > On Tue, Mar 28, 2017 at 04:57:08PM +0200, Michael Gmelin wrote: > > > > > > These are in to align to > > > > > > TEST_TEST_TARGET=test, otherwise it would look like this: > > > > > > TEST_USES=      compiler:c++11-lib > > > TEST_TEST_TARGET=test > > > > > > (replaced tabs by spaces for email) > > > > > > Would this actually be preferred? > > Keep in mind, "preferred" by danfe does not imply "preferred" by me, > > or anyone else other than danfe. > FWIW, I didn't use the word "preferred" at all in my reply, and yet > Michael said it "makes sense". > > > > > If we expanded the PH to cover all danfe's objections, it would be > > 600 pages long. > Mark, come on.  I'm not enforcing anything, and in fact you can find > lots of examples of what I've said above already in the ports.  You > make it sound like I'm trying to formalize whether one must or must not > put a after (len(knob) % 8) == 7) knobs, like OPTIONS_DEFAULT, > which I'm certainly not. > > Again, I'm just trying to keep things consistent, not enforce any rules. > Also, as you've surely noticed, when I try to explain why things are > (IMHO) better be done one way than another I *always* try to bring some > rationale behind it, and I'm open for a discussion.  If people disagree, > they are more than welcome to jump in and convince me otherwise. > And right there is the problem:  The implicit assumption in your mind (and believe me, it comes through loud and clear in every message you post), that for something to be correct, YOU must be convinced it is correct. -- Ian > I don't want to control ports' style(9), but I do want ports to be 1) > consistent, and 2) pretty looking (as long as #1 holds).  You might > argue that #2 is subjective, but history shows that most of the ports > are (to my liking), and just some of them aren't.  So again (sorry), > it's mostly about consistency, not my "preferred" way of doing things. > > ./danfe >