From owner-freebsd-ports@FreeBSD.ORG Thu Nov 13 02:13:25 2014 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BF74ABB0; Thu, 13 Nov 2014 02:13:25 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "funkthat.com", Issuer "funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9C97DBDF; Thu, 13 Nov 2014 02:13:25 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id sAD2DOAO036462 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 12 Nov 2014 18:13:24 -0800 (PST) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id sAD2DOS9036461; Wed, 12 Nov 2014 18:13:24 -0800 (PST) (envelope-from jmg) Date: Wed, 12 Nov 2014 18:13:24 -0800 From: John-Mark Gurney To: Bryan Drewery Subject: Re: review of new tcpcrypt port... Message-ID: <20141113021323.GE24601@funkthat.com> Mail-Followup-To: John-Mark Gurney , Bryan Drewery , ports@FreeBSD.org References: <20141108100709.GF24601@funkthat.com> <20141113001649.GB24601@funkthat.com> <5463FCF6.4040901@FreeBSD.org> <20141113011157.GD24601@funkthat.com> <5464109B.8020204@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5464109B.8020204@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Wed, 12 Nov 2014 18:13:24 -0800 (PST) Cc: ports@FreeBSD.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2014 02:13:25 -0000 Bryan Drewery wrote this message on Wed, Nov 12, 2014 at 19:59 -0600: > On 11/12/2014 7:11 PM, John-Mark Gurney wrote: > > Bryan Drewery wrote this message on Wed, Nov 12, 2014 at 18:36 -0600: > >> On 11/12/2014 6:16 PM, John-Mark Gurney wrote: > >>> John-Mark Gurney wrote this message on Sat, Nov 08, 2014 at 02:07 -0800: > >>>> I'd like someone to review the attached port for me to commit... It > >>>> contains a daemon to run on divert sockets to implement the tcpcrypt > >>>> protocol. I have tested this port w/ HEAD and it works fine w/ the > >>>> attached patch... > >>>> > >>>> The included patch has been submitted upstream and committed, but a > >>>> new release has not yet been released. > >>>> > >>>> portlint -A looks fine. > >>> > >>> As I haven't received a review, in a couple more days, probably Friday, > >>> I'll commit the port... > >>> > >>> Thanks. > >>> > >> > >> Can you include the security/Makefile bit in the patch too please? > > > > Hmm... Thought I did, but I clearly did not... Fixed... I've attached > > the latest version of the port.. > > > >> Have you ran it through poudriere? At the very least 'env DEVELOPER=1 > >> make stage' and 'make check-plist' are required. Portlint is not > >> sufficient, nor can it even be trusted in all cases. > > > > I didn't do poudriere, but I did all the building w/ DEVELOPER=1 > > set, which did fix a few things.. > > Well 'make check-plist' must be ran manually. I think I'll enable it > automatically soon. I've avoided it because it would break Redports even > more. > > > > > Looks like port test from porttools as documented at: > > https://www.freebsd.org/doc/en/books/porters-handbook/testing-porttools.html > > > > Is wrong.. you need to be in the port directory for it to work... > > > > Ugh. That's a bad page. I'm working on a blog article for this case to > get out soon. I may get it into the Journal as well. > > >> If you check those and get back to me I'll approve it. > > > > Thanks... > > > >> Usually you'd need a port commit bit to commit anything, or an approval > >> (which is different than a review). I hate our process, but that's how > >> it is. Poke people in #bsdports on EFNet, or me on IRC, for > >> approvals/reviews in the future. > > > > Well, I'm fine w/ someone else committing the port, just trying to save > > someone the work, and trying to get it into the tree in a timely > > manner.. I viewed the review as approval... Guess I should have made > > it more clear in my original request... > > > > btw, the included patch has been upstreamed, but they haven't tagged a > > new rc yet... > > > > 3 comments: > > 1. No need for commented line in the Makefile ahh, good point... > 2. Only 1 WWW for pkg-descr There are a number of ports that violate this rule then... Just in security, we have: # find . -name pkg-descr -exec grep ^WWW {} + | sed -e 's/:.*//' | sort | uniq -c | grep -v 1 2 ./openssl/pkg-descr 2 ./p5-File-Scan-ClamAV/pkg-descr 2 ./p5-GnuPG-Interface/pkg-descr 2 ./p5-Net-OpenID-Server/pkg-descr 2 ./py-m2crypto/pkg-descr 2 ./py-oauth2client/pkg-descr I'm fine w/ only one, but I just copied other ports.. :) > 3. If 'make check-plist' passes then I approve it and you can commit > yourself. I am mentoring several src committers for ports and getting > them bits after enough work, so just ping me whenever you have more. yes, check-plist passes... Oh, I realized that the second WWW isn't even correct anymore.. I'll just drop it and commit.. Thanks! -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."