From owner-svn-src-all@freebsd.org Sun Jun 28 19:05:36 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D201C98F853; Sun, 28 Jun 2015 19:05:36 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pd0-x234.google.com (mail-pd0-x234.google.com [IPv6:2607:f8b0:400e:c02::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 99DA41ECA; Sun, 28 Jun 2015 19:05:36 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pdjn11 with SMTP id n11so103801951pdj.0; Sun, 28 Jun 2015 12:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=YDb5KKAycJ4U+Hhbb9YDLEMX1y+s3Ktpd7A1GinoEXg=; b=DMSDVMdjKXLwSXNBTz9pfMyOexVMtmMhDY+3gfTp9G5h4czXYf/bc2fx5kQnfXFjKy MNQ7YGXVCmNta8747Pk4COdLfmKGD+ZHsuSlH5foHVGWCsjZjYHoENW+ZBNwlHczTtHY fF+na/muNLYOg7rV8NyCDnSON/tnaVbcuvF2mxSjbmiHXQSNc3tsZx6Pnq85WCugUVac KNTnKCBK9BOPRaCahHZn4XSub4uR/lP4hOpWGCP6NYLvX7sVAKhWoEVycfsyJMkh8i23 n4FSfenS/KgmOpfPGBAWMJjn7PmAcHH6KiEVFSkKzLMD0wVTwZ0EpMcqgPgCz7ppz8Dq erHw== X-Received: by 10.66.158.65 with SMTP id ws1mr21898568pab.18.1435518336142; Sun, 28 Jun 2015 12:05:36 -0700 (PDT) Received: from ?IPv6:2601:602:8001:6c87:498a:c84e:b7b:1b16? ([2601:602:8001:6c87:498a:c84e:b7b:1b16]) by mx.google.com with ESMTPSA id b10sm39800192pdo.84.2015.06.28.12.05.35 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 28 Jun 2015 12:05:35 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r284912 - head/usr.bin/units From: Garrett Cooper X-Mailer: iPhone Mail (12F70) In-Reply-To: <201506281643.t5SGh7D9009454@svn.freebsd.org> Date: Sun, 28 Jun 2015 12:05:34 -0700 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <201506281643.t5SGh7D9009454@svn.freebsd.org> To: Julio Merino X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jun 2015 19:05:36 -0000 > On Jun 28, 2015, at 09:43, Julio Merino wrote: >=20 > Author: jmmv > Date: Sun Jun 28 16:43:07 2015 > New Revision: 284912 > URL: https://svnweb.freebsd.org/changeset/base/284912 >=20 > Log: > Only initialize libedit when necessary >=20 > The code path to support units conversions from the command line > need not initialize neither libedit nor the history. Therefore, only do > that when in interactive mode. >=20 > This hides the issue reported in PR bin/201167 whereby running commands > of the form 'echo "$(units ft in)"' would corrupt the terminal. The real= > issue causing the corruption most likely still remains somewhere. >=20 > PR: bin/201167 > Differential Revision: D2935 > Reviewed by: eadler Jenkins has been so messed up recently with timeouts and the like that it's h= ard to tell where things went south.. Can you please add your TERM and locale variables to the PR? I suspect that i= t might be a related issue..=