From owner-svn-src-head@freebsd.org Sun Feb 19 18:02:12 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B99DACE51BD; Sun, 19 Feb 2017 18:02:12 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C1C8DFF; Sun, 19 Feb 2017 18:02:12 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id v77so10715887wmv.0; Sun, 19 Feb 2017 10:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=w6c4g6Y/3btNcLa5ErIxKOgIl65Gqw8t/V1429NZb5M=; b=gVQrVUzulv+IL9WBgSGTcAjcDdimSmnK5Se2C5gA29Qt5vESrTNhANdKl62xmWPpd7 rLKmbFSsVXTJjbn3t55xZ/qOgEfg6PQm1YmtlLfoNc1vKnG51IgE2VP08DPWIcfprhHk rPqzzxYxBeJiuVpIHN89TeCGNH2qwYae4iEE0Slfuk5OLP+cl8T1/BOqqXrIlto2x0vR ugnGBhjYQbSBOMTS/u9uBsULCL71HcHjWQthizuByHUs4RYIVrZQrB2DoLGfG9Qp3Kjf uY57krrhky0X8fqF+D5uYrReS9HgBD+Dg8jSfIk0MXLxsG2a7qziwnThU66cKvTG+bZA UmtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=w6c4g6Y/3btNcLa5ErIxKOgIl65Gqw8t/V1429NZb5M=; b=gF4JsTlnKcfWBBULtghOKJoR5AW3S/AMLNYwJ7/1VJc4+6pz/X+AgsZD3jN8Tl1PKN JDb9DUNp2D5StRaAuaX3G7VPcVNVaeyTPtYjMfbEedJbScXqZLdy6TKw0pgiNfRsBifQ +aVULUG2KZSSTbFWIVfUrZucphoGt1ym+gCmUv6OsZvo8+E91AMmRJ4QwAh96q9Vjt6R +d8dGKki/nvlDiACZe2+PqW0mGuwabdy0EIUUDW2WW6GEO3k/kxW9x9FZOEPCPXAQuHO L0hVKq/bnYH/GI4uCzQq5893jSFbFTcGGT5xrorryEC7GXU9pBeoWwnIwxO+MYjPQ2+o dpug== X-Gm-Message-State: AMke39ln5NAhdpDy2RdIy1SiZTuNii1DgEi222PX/1oBjwOt045kOVsly1jM62miqhg1gg== X-Received: by 10.28.229.193 with SMTP id c184mr8938968wmh.83.1487527330060; Sun, 19 Feb 2017 10:02:10 -0800 (PST) Received: from brick (gbh5.clarehall.cam.ac.uk. [131.111.224.37]) by smtp.gmail.com with ESMTPSA id l130sm10329454wmf.0.2017.02.19.10.02.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Feb 2017 10:02:09 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Sun, 19 Feb 2017 18:02:07 +0000 From: Edward Tomasz Napierala To: Cy Schubert Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313943 - head/sbin/mdconfig Message-ID: <20170219180207.GA6808@brick> Mail-Followup-To: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201702191608.v1JG8wAN068829@repo.freebsd.org> <201702191619.v1JGJxkw013169@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201702191619.v1JGJxkw013169@slippy.cwsent.com> User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Feb 2017 18:02:12 -0000 On 0219T0819, Cy Schubert wrote: > In message <201702191608.v1JG8wAN068829@repo.freebsd.org>, Edward Tomasz > Napier > ala writes: > > Author: trasz > > Date: Sun Feb 19 16:08:58 2017 > > New Revision: 313943 > > URL: https://svnweb.freebsd.org/changeset/base/313943 > > > > Log: > > Make mdconfig(8) not segfault when the kernel returns garbage data. > > > > MFC after: 2 weeks > > Sponsored by: DARPA, AFRL > > > > Modified: > > head/sbin/mdconfig/mdconfig.c > > > > Modified: head/sbin/mdconfig/mdconfig.c > > ============================================================================= > > = > > --- head/sbin/mdconfig/mdconfig.c Sun Feb 19 14:53:59 2017 (r31394 > > 2) > > +++ head/sbin/mdconfig/mdconfig.c Sun Feb 19 16:08:58 2017 (r31394 > > 3) > > @@ -452,8 +452,8 @@ md_list(const char *units, int opt, cons > > } > > gc = &pp->lg_config; > > type = geom_config_get(gc, "type"); > > - if (strcmp(type, "vnode") == 0 || > > - strcmp(type, "preload") == 0) { > > + if (type != NULL && (strcmp(type, "vnode") == 0 || > > + strcmp(type, "preload") == 0)) { > > file = geom_config_get(gc, "file"); > > if (fflag != NULL && > > strcmp(fflag, file) != 0) > > > > > > I wonder why the kernel is returning garbage data? Because of a bug. I hadn't tracked that down yet, though, and while kernel should be trusted, some additional error checking won't hurt.