From owner-svn-src-all@freebsd.org  Fri Jul 10 06:47:15 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id ACCAD997934;
 Fri, 10 Jul 2015 06:47:15 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9BA18213;
 Fri, 10 Jul 2015 06:47:15 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.70])
 by repo.freebsd.org (8.14.9/8.14.9) with ESMTP id t6A6lFfC075327;
 Fri, 10 Jul 2015 06:47:15 GMT (envelope-from ed@FreeBSD.org)
Received: (from ed@localhost)
 by repo.freebsd.org (8.14.9/8.14.9/Submit) id t6A6lFFf075326;
 Fri, 10 Jul 2015 06:47:15 GMT (envelope-from ed@FreeBSD.org)
Message-Id: <201507100647.t6A6lFFf075326@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: ed set sender to ed@FreeBSD.org
 using -f
From: Ed Schouten <ed@FreeBSD.org>
Date: Fri, 10 Jul 2015 06:47:15 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r285350 - head/sys/kern
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jul 2015 06:47:15 -0000

Author: ed
Date: Fri Jul 10 06:47:14 2015
New Revision: 285350
URL: https://svnweb.freebsd.org/changeset/base/285350

Log:
  Let listen() return EDESTADDRREQ when not bound.
  
  We currently return EINVAL when calling listen() on a UNIX socket that
  has not been bound to a pathname. If my interpretation of POSIX is
  correct, we should return EDESTADDRREQ: "The socket is not bound to a
  local address, and the protocol does not support listening on an unbound
  socket."
  
  Return EDESTADDRREQ instead when not bound and not connected.
  
  Differential Revision:	https://reviews.freebsd.org/D3038
  Reviewed by:	gnn, network

Modified:
  head/sys/kern/uipc_usrreq.c

Modified: head/sys/kern/uipc_usrreq.c
==============================================================================
--- head/sys/kern/uipc_usrreq.c	Fri Jul 10 05:51:36 2015	(r285349)
+++ head/sys/kern/uipc_usrreq.c	Fri Jul 10 06:47:14 2015	(r285350)
@@ -736,8 +736,10 @@ uipc_listen(struct socket *so, int backl
 
 	UNP_PCB_LOCK(unp);
 	if (unp->unp_vnode == NULL) {
+		/* Already connected or not bound to an address. */
+		error = unp->unp_conn != NULL ? EINVAL : EDESTADDRREQ;
 		UNP_PCB_UNLOCK(unp);
-		return (EINVAL);
+		return (error);
 	}
 
 	SOCK_LOCK(so);