From owner-freebsd-current@FreeBSD.ORG Tue Jun 20 00:55:43 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2128D16A482 for ; Tue, 20 Jun 2006 00:55:43 +0000 (UTC) (envelope-from shigeru@iij.ad.jp) Received: from otm-mgo01.iij.ad.jp (otm-mgo01.iij.ad.jp [210.138.20.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 830C643D45 for ; Tue, 20 Jun 2006 00:55:41 +0000 (GMT) (envelope-from shigeru@iij.ad.jp) Received: OTM-MO(otm-mgo01) id k5K0teG9014780; Tue, 20 Jun 2006 09:55:40 +0900 (JST) DomainKey-Signature: a=rsa-sha1; s=omgo; d=iij.ad.jp; c=nofws; q=dns; h=date:message-id:to:from:x-mailer:mime-version: content-type:content-transfer-encoding; b=hZU4Qba+HFtNVSrgp+IuqwqxeHY5Y9NKF0jfVFDooQjHpCLLohYN3HVmlolRkturL T96ZIwWCRmsdW8fnD6zXA== Received: OTM-MIX(otm-mix00) id k5K0teHk079495; Tue, 20 Jun 2006 09:55:40 +0900 (JST) Received: from localhost (mercury.iij.ad.jp [192.168.184.90]) by rsmtp.iij.ad.jp (OTM-MR/rsmtp) id k5K0tcsM023569 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NOT) for ; Tue, 20 Jun 2006 09:55:40 +0900 (JST) Date: Tue, 20 Jun 2006 09:55:38 +0900 (JST) Message-Id: <20060620.095538.55718139.shigeru@iij.ad.jp> To: freebsd-current@freebsd.org From: YAMAMOTO Shigeru X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Tue_Jun_20_09_55_38_2006_364)--" Content-Transfer-Encoding: 7bit Subject: tcp_syncache.hashbase should be zero cleared before calling mtx_init() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2006 00:55:43 -0000 ----Next_Part(Tue_Jun_20_09_55_38_2006_364)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi, all, When I testing -current, my pc panic at booting time. Message is 'lock "tcp_sc_head" XXXX already initialized'. So, I read @src/sys/netinet/tcp_syncache.c. It seems me that 'tcp_syncache.hashbase' should be zero cleared before calling, 289 mtx_init(&tcp_syncache.hashbase[i].sch_mtx, "tcp_sc_head 289 ", 290 NULL, MTX_DEF); Is it right? Thanks, ------- YAMAMOTO Shigeru P.S. currently, I'm using following local patch. ----Next_Part(Tue_Jun_20_09_55_38_2006_364)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="tcp_syncache.c.diff" Index: sys/netinet/tcp_syncache.c =================================================================== RCS file: /share/cvsup/FreeBSD/current/usr/src/sys/netinet/tcp_syncache.c,v retrieving revision 1.92 diff -u -r1.92 tcp_syncache.c --- sys/netinet/tcp_syncache.c 18 Jun 2006 13:03:42 -0000 1.92 +++ sys/netinet/tcp_syncache.c 19 Jun 2006 03:01:00 -0000 @@ -281,7 +281,7 @@ /* Allocate the hash table. */ MALLOC(tcp_syncache.hashbase, struct syncache_head *, tcp_syncache.hashsize * sizeof(struct syncache_head), - M_SYNCACHE, M_WAITOK); + M_SYNCACHE, M_WAITOK | M_ZERO); /* Initialize the hash buckets. */ for (i = 0; i < tcp_syncache.hashsize; i++) { ----Next_Part(Tue_Jun_20_09_55_38_2006_364)----