From owner-svn-src-head@FreeBSD.ORG Mon Dec 6 19:36:18 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9A5DC106566B; Mon, 6 Dec 2010 19:36:18 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 183628FC16; Mon, 6 Dec 2010 19:36:17 +0000 (UTC) Received: by vws9 with SMTP id 9so5041472vws.13 for ; Mon, 06 Dec 2010 11:36:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:sender:received :in-reply-to:references:from:date:x-google-sender-auth:message-id :subject:to:cc:content-type:content-transfer-encoding; bh=Lq8M+Itiyj1tK91ut9Lx4RUNYajVqqsN0iKkdJ0mIgc=; b=VZ+vJRXnpT0VF27lZWDRs9iui5nBPKkFWjjQfSvz2zr36abjsR6GYwXsqQ6uKE5XN4 AI/Di62sfQqRDSdc6juNFxLPJ+ajtgpu5mSCaJO/56QA1hL8hw5ovK22ET8HqHJukMc7 DBAKXTNORa76nAgYdZSA02BBSbU9aYI8gaT88= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=sIASx5q6CO8KHBIXJrHRRvP8JbNauoyAGk99vJpejDcZsuTI66obpqoq6SXgSXbYiR +AMz4/C1aI4Z9zBaesnQ6XBquf80bDdsG9y1sJYtblfSR4zPSgG6i9H5Lth67qU+7/0d +3jbQsBCYz3zbsNMXba2D2v1aLeyYMaPdzX/8= Received: by 10.229.189.72 with SMTP id dd8mr4811513qcb.123.1291664177170; Mon, 06 Dec 2010 11:36:17 -0800 (PST) MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.229.231.143 with HTTP; Mon, 6 Dec 2010 11:35:36 -0800 (PST) In-Reply-To: <20101206192238.GB1936@garage.freebsd.pl> References: <201012061218.oB6CI3oW032770@svn.freebsd.org> <20101206184453.GA1936@garage.freebsd.pl> <20101206192238.GB1936@garage.freebsd.pl> From: Ivan Voras Date: Mon, 6 Dec 2010 20:35:36 +0100 X-Google-Sender-Auth: 71oQAA6UuD9viosD3cEO7VOjnCA Message-ID: To: Pawel Jakub Dawidek Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216230 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Dec 2010 19:36:18 -0000 On 6 December 2010 20:22, Pawel Jakub Dawidek wrote: > On Mon, Dec 06, 2010 at 07:44:53PM +0100, Pawel Jakub Dawidek wrote: >> On Mon, Dec 06, 2010 at 12:18:03PM +0000, Ivan Voras wrote: >> > Author: ivoras >> > Date: Mon Dec =C2=A06 12:18:02 2010 >> > New Revision: 216230 >> > URL: http://svn.freebsd.org/changeset/base/216230 >> > >> > Log: >> > =C2=A0 Use GEOM stripesize field when calculating ashift. This will en= able correct >> > =C2=A0 alignment on drives with large sector sizes (e.g. 4 KiB) but th= e >> > =C2=A0 implementation might need to be revisited if devices with large= stripesizes >> > =C2=A0 appear (e.g. if RAID controllers or flash drives start using th= e field), >> > =C2=A0 probably by introducing a physsectorsize field in GEOM provider= s. >> >> Please back this out as soon as possible! >> >> > =C2=A0 Discussed with: mav, mostly silence on freebsd-geom@ and freebs= d-fs@ >> >> Guess why it wasn't picked up by anyone? > > In other words... Stop hack around. This is so irritating. > > If disk lies about its sector size, add quirks at the layer where disk > is discovered. Don't hack ZFS, UFS, any other file system and GEOM > classes, because its easiest for you. It would be best if you could just > leave it to mav@ who knows this area and knows what he is doing. Those > drive-by hacks of yours are really doing more evil than good. I regard your personal opinion on this topic in little regard, as you have too much of it. Please persuade me on technical grounds why ashift, a property intended for address alignment, should not be set in this way. If your answer is "I don't know but you are still wrong because I say so" I will respect it and back it out but only until I/we discuss the question with upstream ZFS developers. >From my POW, this is similar to changing UFS default fragment size to match stripesize, which is a patch I also intend to commit (after a review by mckusick, or course).