From owner-freebsd-bugs@freebsd.org Sun Oct 15 15:39:38 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6F13DE45624 for ; Sun, 15 Oct 2017 15:39:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5C1497DC8D for ; Sun, 15 Oct 2017 15:39:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v9FFdcmO047084 for ; Sun, 15 Oct 2017 15:39:38 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 223031] bsdgrep behaves incorrectly when given multiple patterns Date: Sun, 15 Oct 2017 15:39:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: J.deBoynePollard-newsgroups@NTLWorld.COM X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Oct 2017 15:39:38 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223031 Bug ID: 223031 Summary: bsdgrep behaves incorrectly when given multiple patterns Product: Base System Version: 10.3-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: J.deBoynePollard-newsgroups@NTLWorld.COM See https://unix.stackexchange.com/questions/398223/ for how to replicate t= his. Some investigation reveals that this is apparently down to the pmatch objec= t in the procline() function not being used properly. In the outer loop, it is being used to track the start and end position wit= hin the current input line. However, if multiple patterns are provided, in the inner loop it is overwritten by the first call to fastexec()/regexec() and = not reinitialized with st and l->len for the next. The (re)initialization code for pmatch.rm_so and pmatch.rm_eo needs to be m= oved down into the inner loop, so that it is set correctly for every pattern, not just for the first one. This also means that the if (st =3D=3D (size_t)pmatch.rm_so) code in the outer loop is probably wrong, too, as that will only detect the output of the last fastexec()/regexec() call for the last of multiple patte= rns. Perhaps there should be one pmatch object per pattern. --=20 You are receiving this mail because: You are the assignee for the bug.=