From owner-svn-src-head@freebsd.org Fri Mar 10 18:06:34 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34A79D062CC; Fri, 10 Mar 2017 18:06:34 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 03F2495A; Fri, 10 Mar 2017 18:06:33 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from [192.168.0.6] (75-173-99-247.albq.qwest.net [75.173.99.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id 401A41928BA; Fri, 10 Mar 2017 18:06:25 +0000 (UTC) Subject: Re: svn commit: r311849 - in head: . sys/amd64/conf sys/arm64/conf sys/conf sys/dev/e1000 sys/i386/conf sys/mips/conf sys/modules sys/modules/em sys/modules/igb sys/powerpc/conf To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <201701100323.v0A3NMAI045868@repo.freebsd.org> <20170215100637.2xsyyu46odzig4c4@dhcp-3-221.uk.xensource.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Sean Bruno Message-ID: Date: Fri, 10 Mar 2017 11:06:21 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170215100637.2xsyyu46odzig4c4@dhcp-3-221.uk.xensource.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LndQjCigaf82Mf6CitHws2CK36wdbG4Uv" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 18:06:34 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LndQjCigaf82Mf6CitHws2CK36wdbG4Uv Content-Type: multipart/mixed; boundary="xJpSIOetUKKgKgpJk1aueiJTNpx3Eb7ak"; protected-headers="v1" From: Sean Bruno To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r311849 - in head: . sys/amd64/conf sys/arm64/conf sys/conf sys/dev/e1000 sys/i386/conf sys/mips/conf sys/modules sys/modules/em sys/modules/igb sys/powerpc/conf References: <201701100323.v0A3NMAI045868@repo.freebsd.org> <20170215100637.2xsyyu46odzig4c4@dhcp-3-221.uk.xensource.com> In-Reply-To: <20170215100637.2xsyyu46odzig4c4@dhcp-3-221.uk.xensource.com> --xJpSIOetUKKgKgpJk1aueiJTNpx3Eb7ak Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 02/15/17 03:06, Roger Pau Monn=E9 wrote: > On Tue, Jan 10, 2017 at 03:23:22AM +0000, Sean Bruno wrote: >> Author: sbruno >> Date: Tue Jan 10 03:23:22 2017 >> New Revision: 311849 >> URL: https://svnweb.freebsd.org/changeset/base/311849 >> >> Log: >> Migrate e1000 to the IFLIB framework: >> - em(4) igb(4) and lem(4) >> - deprecate the igb device from kernel configurations >> - create a symbolic link in /boot/kernel from if_em.ko to if_igb.ko >=20 > This linking causes mfsBSD to choke when building an image from HEAD. I= t tries > to issue the following command: >=20 > ${_v}${CP} -rp ${_BOOTDIR}/kernel ${WRKDIR}/disk/boot >=20 > Which fails when finding the symbol link. I can send a patch to change = that to > -Rp, which would work fine, but wouldn't it be better to either complet= ely > remove if_igb.ko, or simply copy if_em.ko to if_igb.ko? >=20 > I'm wondering if for example anyone strips down it's /boot/kernel/ manu= ally, by > removing unused modules, and what would happen if if_em.ko is removed b= ut not > if_igb.ko. >=20 > Roger. >=20 >=20 Well, this was my naive attempt to make upgrades for users to be non-eventful in the event they have "if_igb_load=3DYES" in their loader.conf instead of having it built into their kernel. If the -Rp works, I'll add that instead. sean --xJpSIOetUKKgKgpJk1aueiJTNpx3Eb7ak-- --LndQjCigaf82Mf6CitHws2CK36wdbG4Uv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEuq1GMucSHejSCZfdEgHvyh5yfmQFAljC6x1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEJB QUQ0NjMyRTcxMjFERThEMjA5OTdERDEyMDFFRkNBMUU3MjdFNjQACgkQEgHvyh5y fmQtTQgAgm5fH7Nc05P+5ghIZO/jRb/IAZy0kSaL3L/fi2Cu2QUbjyz+WXO2V30T 1wqKFzygllp+K46EMPa9eO/3hcs2YGTYG/hor6sIim1HER7NqCBU8VJrhaDAaxE6 bNVkHqCmsMjRNGWZndvOICUe14PD9ahjIe0Lf5t+uc9qSeHpNAz1JJheaREyAsiW 97yrsxjUsHaXSjYWdIwlSRThkU6SKrbg8IgsjSPV0viIw2t9zL8gJpkuj09lLoYb Lf000KgxmvvZUMESgTQPMJyMi4MvH+LiZII+agGlks5pRutjufXs6cNqgDXfeH2D hdlvr69Z7FBGoSg2LCBZUGmhxpmoSw== =FvI9 -----END PGP SIGNATURE----- --LndQjCigaf82Mf6CitHws2CK36wdbG4Uv--