From owner-freebsd-current@FreeBSD.ORG Sat Nov 22 20:46:17 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A7AD016A4CE; Sat, 22 Nov 2003 20:46:17 -0800 (PST) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 07A2F43FE0; Sat, 22 Nov 2003 20:46:15 -0800 (PST) (envelope-from eischen@vigrid.com) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mail.pcnet.com (8.12.10/8.12.1) with ESMTP id hAN4kD1G019182; Sat, 22 Nov 2003 23:46:15 -0500 (EST) Date: Sat, 22 Nov 2003 23:46:13 -0500 (EST) From: Daniel Eischen X-Sender: eischen@pcnet5.pcnet.com To: Alfred Perlstein In-Reply-To: <20031123023649.GG35957@elvis.mu.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: re@freebsd.org cc: current@freebsd.org Subject: Re: [PATCH] please review. file descriptor passing for libc_r. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Nov 2003 04:46:17 -0000 On Sat, 22 Nov 2003, Alfred Perlstein wrote: > This should make things work properly for apps that are linked > against libc_r and use filedescriptor passing. > > Can someone review and approve it please? This isn't needed. Any time a file descriptor is used, a call should first be made to _FD_LOCK() which ends up calling _thread_fd_lock() which then calls _thread_fd_table_init() for the file descriptor. If there's a reason that this is necessary, then I think it is just covering up another problem. I think I made this same comment a couple of years ago ;-) -- Dan Eischen