Date: Thu, 24 Jun 2010 22:49:33 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: python@FreeBSD.org Cc: perky@FreeBSD.org Subject: Re: [PATCH] ioctl(2) fixes for 64-bit platforms Message-ID: <201006242249.36828.jkim@FreeBSD.org> In-Reply-To: <201006241438.57414.jkim@FreeBSD.org> References: <201006241438.57414.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 24 June 2010 02:38 pm, Jung-uk Kim wrote: > Python handles ioctl(2) strangely and causes warnings on 64-bit > platforms. The analysis was originally posted here: > > http://docs.freebsd.org/cgi/mid.cgi?201006231708.40032.jkim > > Now I made more complete patch for all Python ports and it is > available from here: > > http://people.freebsd.org/~jkim/python-fcntlmodule.diff I have updated the patch: http://people.freebsd.org/~jkim/python-fcntlmodule2.diff > Note I also fixed a Linuxism of fcntl(2) for python31. They use > 'long' for the optional third argument of fcntl() unlike POSIX and > *BSD. It's okay for little-endian or 32-bit platforms but I guess > it is bad for big-endian LP64 machines. I think it was my mis-understanding as it doesn't pass the pointer, withdrawn. > While I was here, I updated test cases of ioctl() for all Python > ports. I also added FreeBSD -CURRENT for python31 but I didn't > bother test cases of older releases. :-) Now the new patch is much simpler and it should be upstream-worthy, I think. Jung-uk Kim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006242249.36828.jkim>