From owner-cvs-all Sun Jul 16 16:13: 6 2000 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.49]) by hub.freebsd.org (Postfix) with ESMTP id 360C337BB8A; Sun, 16 Jul 2000 16:13:00 -0700 (PDT) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.9.3/8.9.3) with ESMTP id RAA77387; Sun, 16 Jul 2000 17:12:57 -0600 (MDT) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id RAA56337; Sun, 16 Jul 2000 17:12:35 -0600 (MDT) Message-Id: <200007162312.RAA56337@harmony.village.org> To: Matt Dillon Subject: Re: cvs commit: src/usr.sbin/usbd usbd.c Cc: "Jordan K. Hubbard" , Peter Wemm , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "Sun, 16 Jul 2000 15:48:53 PDT." <200007162248.PAA09181@earth.backplane.com> References: <200007162248.PAA09181@earth.backplane.com> <2076.963534850@localhost> Date: Sun, 16 Jul 2000 17:12:35 -0600 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <200007162248.PAA09181@earth.backplane.com> Matt Dillon writes: : : :> Correct an additional off-by-one bug and buffer overflow. A malloc() : :> was being made one byte too short, and the string assembled in it was not : :> null terminated. The string was passed to regcomp() so it never matched : :> anything in /etc/usbd.conf. This is the cause of usbd not working for the : :> last few days.. The new malloc.conf default of AJ triggered this. : : : :Oh god, did you have to say that? Now phk will be INSUFFERABLE for : :weeks. :-) : : : :- Jordan : : AJ ? Guys, 'J' as a default to malloc.conf is a disaster for performance. : There are many programs which allocate large buffers and only use : small portions of them. We *CANNOT* ship with 'J' as a default : for malloc. We'll never SHIP with J as default. It is there only for -current to catch bugs. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message