From owner-svn-src-all@FreeBSD.ORG Sun Dec 1 07:59:50 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CB27EA3D; Sun, 1 Dec 2013 07:59:50 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 253F6169B; Sun, 1 Dec 2013 07:59:49 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id rB17xiI7052730; Sun, 1 Dec 2013 09:59:44 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua rB17xiI7052730 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id rB17xiF5052729; Sun, 1 Dec 2013 09:59:44 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 1 Dec 2013 09:59:44 +0200 From: Konstantin Belousov To: Eitan Adler Subject: Re: svn commit: r258779 - in head/sys/dev: cesa drm drm2/i915 drm2/radeon hatm Message-ID: <20131201075944.GF59496@kib.kiev.ua> References: <201311302216.rAUMGcPA037268@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cIzV5r+THY7s5gYK" Content-Disposition: inline In-Reply-To: <201311302216.rAUMGcPA037268@svn.freebsd.org> User-Agent: Mutt/1.5.22 (2013-10-16) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Dec 2013 07:59:50 -0000 --cIzV5r+THY7s5gYK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 30, 2013 at 10:16:38PM +0000, Eitan Adler wrote: > Author: eadler > Date: Sat Nov 30 22:16:37 2013 > New Revision: 258779 > URL: http://svnweb.freebsd.org/changeset/base/258779 >=20 > Log: > Similar to the (1 << 31) case it is not defined to do (2 << 30). >=20 > Modified: =2E.. > head/sys/dev/drm2/i915/i915_reg.h Revert the drm2/i915 changes from this and following commits now. You did not contacted obvious maintainer of the file. The changes are pointless and make the import of upstream changes harder; for i915_reg.h, much harder. Not to mention that the whole churn is not needed if the -fno-strict-overflow flag is used. --cIzV5r+THY7s5gYK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJSmuxvAAoJEJDCuSvBvK1B0WoP/16VNLuzB5Wpo6h88JFkT6vZ XaaV4R5XhCbpW72Xq93PaOCONqNuNk7tnfYNLgzFMcQbzWrI1RlAO40d4K++AWBN p8SRg5RhHkaihEKs/Ze/8Wm5h2fTR/uDs/0xsQeQf02tkOQDVGyL/4fL2OcpVtAr MddB6t92AU/t4E4kXvLCzeMzbPvDaeQ67C7uJhr8aps5gSUNi3wDaUl9UMC/a2sV 0sbtfasMP4y5N7rCr/Tuz/s4umDhd5sbKdRc2a/uporVZN1RWVvB5ATdJWJpUiOw EYlGZVB0THNaqzn7jj9kz6Smt5vD70mnHhtveEZ65sTBRDuYDCOHPu9btozKpBaU 9I9bTSbwUXlcZZIbpwMvemgPeGASxMEWWShiXeQazvXkQq4NbxE3FViwkwVL+ZcK Vkr64M6XFkn79yKTg3zizZv7R+L/3rH3IN8ryipioC8oivQx2M0TrWH+8tWpbVi1 Yf4V4/LbM2+M4bS5PYmBYyxDL5SmGrQ0QsElCLfUSEQSRyh/pM+osyzzCCiIp92v Piix1H/2RDFSqSe8Fv9TrV1Z2EB7rR32xE23Kh8s6Bx3Ucz+yyBXSTn8hXt5J/r9 EcWDwSDtb1759u+WZ35w3lL51WwlVYbHBW/Y2x3TY60yl89tEZNzucAKkzhAHAXL rJhrYP+sOS4yBeebzt+l =YVrw -----END PGP SIGNATURE----- --cIzV5r+THY7s5gYK--