From nobody Thu May 23 18:20:08 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vlc0W6tWZz5L2Cg for ; Thu, 23 May 2024 18:20:11 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vlc0W6HHgz4vNJ; Thu, 23 May 2024 18:20:11 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716488411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=1T4mmuuaw0VU2hdPF3HnyoWGggYS1mhS6hNy/4cinx4=; b=T7+avK1sprEquJ+lFWOsrjWkZ+6Ds3xU3Ry1eYVBljov3nDnfnY9ZffoWIFRaNl7GhhJM/ wvTv9lMLztYGSF1UfvNQ7r7z1DZzSSAYgOZ2Q1HLXN/WG92WGl3IPhZBiiJLFE6BrGKZ/i LqHcFFEyyB3xnXXTLW5sGJVUzYtuh9P98FpuKf7vZ2Qjd8mRmPnTetA0XEzLClKI28Mfnv UiRR9ihTkJgYVVGzGfhydOD1x3IG/vS5nSkc09uh/z0TLU/+L4Gy1cgzOR+nV2rsZbvwZY pZlA9YJN6jMXugp7rYxRWLwLMPDHs345BVSdcsq9PiKVzmkK6QOF8atOxhkXvQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716488411; a=rsa-sha256; cv=none; b=pBoJPDX2MiokZscRC7cpPi8WlrEkffEeHmPDdK8l9GfCc92PqgN+BRkNbhms0ttah/CBo5 zv2da6X3QpNp72foGkjGly8+Em6Gxalni8shApJflFYyI+bkTImaSIZfyDGOBcVqwqG8RO e+//dx16oRrUiV5JNItmzBHtMbWYlrLWeIZC+armDBL9v2KcNADRVfeAU86sJIDgpsDZUz GFmchH9POTpijKGpCgIt25yKQAvixbc/Sa88mSAevRD6TZBqHgOvLjfHzUwpOmXU/JRQKY USU1zplAGxDqkzZj487+GTkCft9i4hTMpkIeMKWYPq1PglZ5O1u08avFA+yGBg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716488411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=1T4mmuuaw0VU2hdPF3HnyoWGggYS1mhS6hNy/4cinx4=; b=FX6Plt+t50WAJnrg/HNALzxEQRI7aLIf44DDTQvbZdHDgntjinamqsX2QHQc8uT6nhmF8e /QyQasjCTxE+zM3S7tvhiuZ0rzOyLYJrZ218KTVsCFWZzZaL0f7e2mp34qDd07zzDN+hBZ xDslChPYINciLyrwaxC7owOfNU5TAHhDWRM3hHlPhUaLIA8ajxriURqOzXiXcPaVby//os O32a1Nt8vlMBUmoQ9oD6hR8jHStIDX8t0REMna7XzXHAbuy1EBUIdvM5EezEY7c1+GGQOI rdYTDLRq07Ce0PciNw687A56TqMf6wKWJmYSfsx2Qruazrube0grHBSZa+kmfQ== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Vlc0W0wdPzKBS; Thu, 23 May 2024 18:20:11 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Thu, 23 May 2024 11:20:08 -0700 From: Gleb Smirnoff To: John Baldwin , Brooks Davis Cc: Dmitry Salychev , Lexi Winter , Mariusz Zaborski , dev-commits-src-all@freebsd.org Subject: generated sources Was: git: 408957613bc0 - main - Regen Message-ID: List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3edabe3b-4b51-401f-ad64-e36c84fd455b@FreeBSD.org> Hi, sorry for slightly diverting the discussion, but looks like this thread is the right place... On Wed, May 22, 2024 at 12:55:24PM -0700, John Baldwin wrote: J> I don't think it's worth reverting at this point. For `make sysent` I would J> suggest 'sysent: Regen' as a commit log in the future. We typically use J> 'src.conf.5: Regen' after running `make makeman`. On Wed, May 22, 2024 at 05:05:14PM +0000, Brooks Davis wrote: B> This is more or less standard practice for generated files. These B> commits are of basically no interest. Historically they had to exist B> because the source file $FreeBSD$ entries were embedded in the generated B> files and thus had to be final. That isn't true any more so I often just B> include them in the origional commit unless I'm doing a lot of minor B> changes to the source files. Is it possible to generate the files during normal kernel build? That would require lua packages installed, but we already almost require git installed to work with FreeBSD sources. Absence of lua can be checked in Makefile and a verbose error message would be printed. Or may be we can use the small lua that we have in the loader? Sorry if the very last suggestion was stupid - really don't have any knowledge in the area. After the xz/liblzma backdoor all the generated code committed manually makes me concerned, as it has 0% chance to get reviewed by community. Just if my suggestion sounds stupid and there is a good reason to have what we have - an automatic generation followed by a manual commit - then please explain this reason. -- Gleb Smirnoff