From owner-cvs-all@FreeBSD.ORG  Sat Jul 26 02:16:51 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C495B37B401; Sat, 26 Jul 2003 02:16:51 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 38DDD43FA3; Sat, 26 Jul 2003 02:16:51 -0700 (PDT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 301572ED464; Sat, 26 Jul 2003 02:16:51 -0700 (PDT)
Date: Sat, 26 Jul 2003 02:16:51 -0700
From: Alfred Perlstein <bright@mu.org>
To: Poul-Henning Kamp <phk@FreeBSD.org>
Message-ID: <20030726091651.GB42924@elvis.mu.org>
References: <200307260732.h6Q7WNqX008568@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200307260732.h6Q7WNqX008568@repoman.freebsd.org>
User-Agent: Mutt/1.4.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/coda coda_fbsd.c coda_vnops.c
	src/sys/compat/linux linux_misc.c src/sys/dev/raidframe
	rf_freebsdkintf.c src/sys/fs/hpfs hpfs_vfsops.c src/sys/fs/msdosfs
	msdosfs_vfsops.c src/sys/fs/ntfs ntfs_vfsops.c src/sys/fs/nwfs ...
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Jul 2003 09:16:52 -0000

* Poul-Henning Kamp <phk@FreeBSD.org> [030726 00:32] wrote:
> phk         2003/07/26 00:32:23 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/coda             coda_fbsd.c coda_vnops.c 
>     sys/compat/linux     linux_misc.c 
>     sys/dev/raidframe    rf_freebsdkintf.c 
>   Log:
>   Add a "int fd" argument to VOP_OPEN() which in the future will
>   contain the filedescriptor number on opens from userland.
>   
>   The index is used rather than a "struct file *" since it conveys a bit
>   more information, which may be useful to in particular fdescfs and /dev/fd/*
>   
>   For now pass -1 all over the place.

This seems like a mistake, it forces one to have a struct filedesc instead
of merely faking up a struct file.

What if one wants to have a cookie without a filedesc?

Am I mistaken?

If there was a discussion on this you might want to float a "Discussed
on: <listname>" in the log messages to shut me up.

-- 
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
 start asking why software is ignoring 30 years of accumulated wisdom.'