From owner-freebsd-net@FreeBSD.ORG Tue Dec 23 22:08:49 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A40AB1065674; Tue, 23 Dec 2008 22:08:49 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.232]) by mx1.freebsd.org (Postfix) with ESMTP id 63DC88FC08; Tue, 23 Dec 2008 22:08:49 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so4073096rvf.43 for ; Tue, 23 Dec 2008 14:08:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=/BT/mrSodMgMoyV0eKLE5iZBMAGCP6xFsctZzlT2b08=; b=BTYxOSe8lK8Q2ubp8oqGvsnu4g8EPCSyFby8TlS2TQCkcMB2NrKK0BnYk3rfUmaJgf uUob1l1hNQOzFfUsW02k0FNUeRclzp+TC0Isi+MK6zm4rVe23dltHc++4kBi11R1J9Pf 9WRr1Km/VZBa11oYrVTCgP1O+MNZ/zPswKvT4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=on1kZEvV9X8kZE9Mrfe0SPO5ojcTQlmC7stpa67ZclJ6uu1D3DCGV2r4E9BDvDG9Fk M4hQBGaPnxp30eZeMgKoHp9zWgQKWWDdIZUiX8//3CFGXF04tWbGEO7beUAq8AzZp0ly EJ97UWVoy+APE5ND53PNj++lSLI6CfFyQ2fKA= Received: by 10.141.203.7 with SMTP id f7mr3937242rvq.125.1230070129184; Tue, 23 Dec 2008 14:08:49 -0800 (PST) Received: by 10.141.37.17 with HTTP; Tue, 23 Dec 2008 14:08:49 -0800 (PST) Message-ID: <3c1674c90812231408h53b16b4as5d3fa242e6d02a10@mail.gmail.com> Date: Tue, 23 Dec 2008 14:08:49 -0800 From: "Kip Macy" Sender: mat.macy@gmail.com To: "Li, Qing" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <55f001c9639d$875f14ec$7202020a@internal.cacheflow.com> <4950F770.3090700@dlr.de> X-Google-Sender-Auth: 5f5fea3d9a27b04b Cc: Qing Li , Hartmut Brandt , freebsd-current@freebsd.org, freebsd-net@freebsd.org Subject: Re: HEADSUP: arp-v2 has been committed X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Dec 2008 22:08:49 -0000 Hi Harti, Let me first preface this e-mail by saying that you and I have had very little contact prior to this. The comments below are meant to explain the point of view of myself and that of a number of other developers with whom I have spoken, not to criticize you or trivialize your point of view. >> - you just removed a lot of code and left the ipNetToMedia table >> entirely disfunctional. >> >> - you obviously did not test the change. Otherwise you would have seen >> that it did not work. Even those of us well versed in networking are not familiar with all subsystems. I know that whenever someone breaks a subsystem that is important to me that I am indignant. That is natural. Although Sam Leffler reviewed much of the code before commit, and I (re-)implemented all of the locking, we have to accept that there was really only one person working on this. He publicly asked for a review many times and made a good faith effort to test all of the dependent network subsystems that he could. However, at the end of the day the code goes in and bugs get fixed as they crop up. Most of us feel that he has done a commendable job in dealing with issues promptly. >> And another point: when changing external interfaces it might be >> possible to ask for a full port build with the changes to look for the >> fall-out on ports. I would say that this commit was a good candidate > to >> get the port maintainers into the boat earlier. >> >> not so happy, The only reasonable way to do a full ports build is to ask portmgr to use the build systems. Although it may now be possible with svn, in the past there was no way for him to do that for out of tree code. Hence portmgr does not share your point of view. What we should have done is grepped for RTM_RESOLVE and the flags that I removed. However, that did not occur to me. He asked on numerous occasions for review and someone should have brought it up then. We do not feel that it is reasonable to hold him solely responsible when he did not act in a unilateral fashion. Thank you for taking care of that bit of breakage. Cheers, Kip -- Als die Nazis die Kommunisten holten, habe ich geschwiegen; ich war ja kein Kommunist. Als sie die Sozialdemokraten einsperrten, habe ich geschwiegen; ich war ja kein Sozialdemokrat. Als sie die Gewerkschafter holten, habe ich nicht protestiert; ich war ja kein Gewerkschafter. Als sie die Juden holten, habe ich geschwiegen; ich war ja kein Jude. Als sie mich holten, gab es keinen mehr, der protestieren konnte.