From owner-cvs-src@FreeBSD.ORG  Mon Dec 13 01:33:18 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A382616A4E2
	for <cvs-src@FreeBSD.org>; Mon, 13 Dec 2004 01:33:16 +0000 (GMT)
Received: from pimout3-ext.prodigy.net (pimout3-ext.prodigy.net
	[207.115.63.102])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3842843D49
	for <cvs-src@FreeBSD.org>; Mon, 13 Dec 2004 01:33:16 +0000 (GMT)
	(envelope-from julian@elischer.org)
Received: from [192.168.1.102] (adsl-216-100-134-143.dsl.snfc21.pacbell.net
	[216.100.134.143])iBD1WvNb373240;	Sun, 12 Dec 2004 20:33:04 -0500
Message-ID: <41BCF149.3090801@elischer.org>
Date: Sun, 12 Dec 2004 17:32:57 -0800
From: Julian Elischer <julian@elischer.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8a3) Gecko/20041017
X-Accept-Language: en, hu
MIME-Version: 1.0
To: Ian Dowse <iedowse@maths.tcd.ie>
References: <200412121411.aa89799@salmon.maths.tcd.ie>
	<41BCDE4D.3020902@elischer.org>
In-Reply-To: <41BCDE4D.3020902@elischer.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: src-committers@FreeBSD.org
cc: cvs-src@FreeBSD.org
cc: Scott Mitchell <scott+freebsd@fishballoon.org>
cc: Scott Long <scottl@FreeBSD.org>
cc: cvs-all@FreeBSD.org
cc: Ceri Davies <ceri@submonkey.net>
cc: Julian Elischer <julian@FreeBSD.org>
Subject: Re: cvs commit: src/sys/sys mouse.h src/sys/dev/usb ums.c usbhid.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Dec 2004 01:33:19 -0000

Julian Elischer wrote:
> Ian Dowse wrote:

>>
>> As pointed out in the PR though, it doesn't seem necessary to change
>> struct mousestatus and the MOUSE_GETSTATUS ioctl API just to make
>> the device work. All other mouse drivers in the tree will need to
>> be updated to initialise the new `dt' field. 

ok that is changed back.


>> There's also one part
>> of the patch that looks as if it could easily break other devices:
>>
>>      ibuf = sc->sc_ibuf;
>>      if (sc->sc_iid) {
>> -        if (*ibuf++ != sc->sc_iid)
>> -            return;
>> +        ibuf++;
>>      }
>>  
>> +    /* The M$ Wireless Intellimouse 2.0 sends 1 extra leading byte of
>> +     * data compared to most USB mice. This byte frequently switches
>> +     * from 0x01 (usual state) to 0x02. I assume it is to allow
>> +     * extra, non-standard, reporting (say battery-life). However
>> +     * at the same time it generates a left-click message on the button
>> +     * byte which causes spurious left-click's where there shouldn't be.
>> +     * This should sort that. */
>> +    if ((sc->sc_ibuf != ibuf) && (sc->sc_ibuf[0] == 0x02)) +        
>> return;
>> +
>>      dx =  hid_get_data(ibuf, &sc->sc_loc_x);
>>      dy = -hid_get_data(ibuf, &sc->sc_loc_y);
>>      dz = -hid_get_data(ibuf, &sc->sc_loc_z);

I'm looking at this.. will treat it separatly from the ABI question.