From owner-freebsd-python@FreeBSD.ORG Wed Sep 7 06:26:22 2011 Return-Path: Delivered-To: freebsd-python@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2511F106566B; Wed, 7 Sep 2011 06:26:22 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yi0-f54.google.com (mail-yi0-f54.google.com [209.85.218.54]) by mx1.freebsd.org (Postfix) with ESMTP id C61BD8FC0A; Wed, 7 Sep 2011 06:26:21 +0000 (UTC) Received: by yib19 with SMTP id 19so5510048yib.13 for ; Tue, 06 Sep 2011 23:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=rvll0i1DMaM1BjOy2Y6W23RIwRQ/xfHscCy64b0sGoI=; b=T6L4TKZwVuQgg/7ZcTHIKrl7W8uKZSLvu8B6qD+m2OHq8RGgHI05RoA54kye01iEJu kVo+DH9sWD6AEUOw2U8SwSc8mDa9isL3mDLVQa2znFwK81z4htk4HciIOkPDAY1++VaY alKCkweJ+ZyppOra/xdEndU2pyN/Ts8Mx1GGY= MIME-Version: 1.0 Received: by 10.150.68.24 with SMTP id q24mr4792101yba.402.1315375363417; Tue, 06 Sep 2011 23:02:43 -0700 (PDT) Sender: lwhsu.freebsd@gmail.com Received: by 10.150.229.16 with HTTP; Tue, 6 Sep 2011 23:02:43 -0700 (PDT) In-Reply-To: <20110906205704.GA38513@freebsd.ifr.lan> References: <20110906205704.GA38513@freebsd.ifr.lan> Date: Wed, 7 Sep 2011 14:02:43 +0800 X-Google-Sender-Auth: uidXFNJksltDfIzJMPYuIT7yHe0 Message-ID: From: Li-Wen Hsu To: Sofian Brabez Content-Type: text/plain; charset=UTF-8 Cc: FreeBSD Python Team Subject: Re: Update of devel/py-twisted to 11.0.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2011 06:26:22 -0000 Hello Sofian, Thanks for working on this, python@ definitely need more power! Please see the reply inline. On Wed, Sep 7, 2011 at 04:57, Sofian Brabez wrote: > Hi python@, > > This afternoon, I've merged my initial update to the twisted related ports with > the patch of lwhsu@ [1]. My patch is there [2]. > > My patch make happy portlint, add LICENSE in each twisted ports and add new > OPTIONS for twistedPair port. And please also add pair_DEPENDS in bsd.python.mk, that is around line 641. > Please lwhsu@ notice than all twisted ports are sharing the > ${PYTHON_SITELIBDIR}/twisted/plugins folder that's why I've replaced the @dirrm > by a @dirrmtry in pkg-plist. Thanks for reminding me this, I think we have @dirrm %%PYTHON_SITELIBDIR%%/twisted/plugins in in devel/py-twistedCore/pkg-plist, and all other twisted ports depends on twistedCore, so we probably don't need to have @dirrm nor @dirrmtry in other ports. They sneaked in my patch because I forget this, so just removing them is fine. (I was planning getting maintainer's approval on general idea then doing a more substantial patch.) Using @dirrmtry is fine, too. > I would like to have your approbation to commit it, and sent it to my mentors > for their approbations, I start working on this one because I took the pr > ports/155570 but lwhsu@ inform me about ports/159954 on #freebsd-python. > > Below the tinderbox build logs: > > http://regis.goodking.org/tb/index.php?action=list_buildports&build=7-sbz&search_port_name=twisted&Go=Go > http://regis.goodking.org/tb/index.php?action=list_buildports&build=8-sbz&search_port_name=twisted&Go=Go > http://regis.goodking.org/tb/index.php?action=list_buildports&build=9-sbz&search_port_name=twisted&Go=Go All looks good, and I also tested building all other ports depends on twisted, all are fine. Is anybody aware non-backward-compatible change? Another thing, I found there is no twisted 11.0.0 distfiles in http://tmrc.mit.edu/mirror/twisted/, that's why I removed them from MASTER_SITES, could you check it again? Please consider my suggestions, thanks! > Regards > > [1] http://people.freebsd.org/~lwhsu/twisted-11.0.0.diff > [2] http://people.freebsd.org/~sbz/twisted-11.0.0.diff > > -- > Sofian Brabez > -- Li-Wen Hsu http://lwhsu.org