Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Nov 2014 14:30:46 +0100
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Olivier Duchateau <olivierd@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r371699 - head/shells/mksh
Message-ID:  <20141121133045.GD12628@ivaldir.etoilebsd.net>
In-Reply-To: <20141121133944.90e94e3c320ee5eff9e2db48@freebsd.org>
References:  <201410291949.s9TJn0sh019321@svn.freebsd.org> <20141119124113.GQ48896@ivaldir.etoilebsd.net> <20141121115534.bd0fd2ad78b8cd28ac5dfda2@freebsd.org> <20141121110304.GA48896@ivaldir.etoilebsd.net> <20141121133944.90e94e3c320ee5eff9e2db48@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--2Z2K0IlrPCVsbNpk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 21, 2014 at 01:39:44PM +0000, Olivier Duchateau wrote:
> On Fri, 21 Nov 2014 12:03:04 +0100
> Baptiste Daroussin <bapt@FreeBSD.org> wrote:
>=20
> > On Fri, Nov 21, 2014 at 11:55:34AM +0000, Olivier Duchateau wrote:
> > > On Wed, 19 Nov 2014 13:41:13 +0100
> > > Baptiste Daroussin <bapt@FreeBSD.org> wrote:
> > >=20
> > > > On Wed, Oct 29, 2014 at 07:49:00PM +0000, Olivier Duchateau wrote:
> > > > > Author: olivierd
> > > > > Date: Wed Oct 29 19:49:00 2014
> > > > > New Revision: 371699
> > > > > URL: https://svnweb.freebsd.org/changeset/ports/371699
> > > > > QAT: https://qat.redports.org/buildarchive/r371699/
> > > > >=20
> > > > > Log:
> > > > >   - Update to R50d
> > > > >   - Drop @dirrm in pkg-plist
> > > > >  =20
> > > > >   PR:	194232
> > > > >   Submitted by:	myself
> > > > >   Approved by:	@miwi (maintainer, timeout)
> > > > >=20
> > > > > Modified:
> > > > >   head/shells/mksh/Makefile
> > > > >   head/shells/mksh/distinfo
> > > > >   head/shells/mksh/pkg-plist
> > > > >=20
> > > > > Modified: head/shells/mksh/Makefile
> > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D
> > > > > --- head/shells/mksh/Makefile	Wed Oct 29 19:41:40 2014	(r371698)
> > > > > +++ head/shells/mksh/Makefile	Wed Oct 29 19:49:00 2014	(r371699)
> > > > > @@ -2,7 +2,7 @@
> > > > >  # $FreeBSD$
> > > > > =20
> > > > >  PORTNAME=3D	mksh
> > > > > -DISTVERSION=3D	R50
> > > > > +DISTVERSION=3D	R50d
> > > >=20
> > > > This goas backward in history and needs to be adapter to the freebs=
d scheme:
> > > > $ pkg version -t r50 r50d
> > > > >
> > > > $ pkg version -t r50 r50.d
> > > > >
> > > >=20
> > > > No user will notice that as an upgrade.
> > >=20
> > > Even if I add PORTEPOCH, for the next releases problem still persists.
> > >=20
> > > Thorsten Glaser uses lower letter like minor version (usually a, b, c=
 or d). Scheme is quite simple.
> > > For example:
> > > R50, next release is R50a and so on (up to c or d).
> > >=20
> > > So if we use PORTEPOCH
> > > pkg version -t r50 r50.d,1
> > > 	    <
> > >=20
> > > It's ok
> > >=20
> > > But the next stable release R51,
> > > pkg version -t r50.d,1 r51
> > > 	    >
> > >=20
> > > Normally R51 is greater than R50d, not here.
> > >=20
> > > I don't known how to solve this problem.
> > >=20
> >=20
> > pkg version -t 50d 50
> > >
> > pkg version -t 50d 51
> > <
> >=20
> > So I would propose:
> > PORTVERSION=3D	50d
> > DISTVERSIONPREFIX=3D	R
> >=20
> > What do you think?
>=20
> Tested, I agree.
>=20
> PORTREVISION is necessary in this case?
>=20
Yes because DISTVERSION will turn 50d into 50.d which is lower than 50 :)

regards,
Bapt

--2Z2K0IlrPCVsbNpk
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlRvPoUACgkQ8kTtMUmk6Ex0QgCgmfTVn7HZa3gQcaHbe5TD7GCh
gfQAoJqZJu2XOQvD7pgp42kSWMp8uGnr
=n6va
-----END PGP SIGNATURE-----

--2Z2K0IlrPCVsbNpk--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141121133045.GD12628>