From owner-freebsd-net@FreeBSD.ORG Fri May 12 13:53:30 2006 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C44DB16A4C1; Fri, 12 May 2006 13:53:30 +0000 (UTC) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7007C43D73; Fri, 12 May 2006 13:53:30 +0000 (GMT) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.11/8.12.11) with ESMTP id k4CDrS8L016557; Fri, 12 May 2006 06:53:28 -0700 (PDT) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.11/8.12.3/Submit) id k4CDrR8Z016556; Fri, 12 May 2006 06:53:27 -0700 (PDT) (envelope-from rizzo) Date: Fri, 12 May 2006 06:53:27 -0700 From: Luigi Rizzo To: Patrick Tracanelli Message-ID: <20060512065327.B16302@xorpc.icir.org> References: <44648E66.6010800@freebsdbrasil.com.br> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <44648E66.6010800@freebsdbrasil.com.br>; from eksffa@freebsdbrasil.com.br on Fri, May 12, 2006 at 10:32:22AM -0300 Cc: Vadim Goncharov , freebsd-net@freebsd.org, freebsd-ipfw@freebsd.org Subject: Re: [patch] ipfw packet tagging X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 May 2006 13:53:31 -0000 On Fri, May 12, 2006 at 10:32:22AM -0300, Patrick Tracanelli wrote: > Vadim Goncharov wrote: > > Hi, All! > > > > I've tried Andrey Elsukov's ipfw "tag/tagged" patches from: > > http://butcher.heavennet.ru/patches/kernel/ipfw_tags/ > > > > Tested on 5.5-PRERELEASE production server with moderate > > load - rock stable [I've also looked through the code - patch > > is small, so it simply can't be any bugs there ;)]. > > > > Personally I very like the idea from original Andrey's letter > > I have tested on 6.1 and works fine too. > > Hope it gets commited. Very useful for altq/dummynet flexibility too. i would, however, like to have a bit more documentation in the patch, in particular: - a manpage patch describing how to use the thing, and also the behaviour in in odd situations (e.g. what happens when we try to tag a packet multiple times ? does the tag survive between the 'input' and 'output' path of ipfw for routed packets, etc ?). I can look this up in the code, but the average user cannot, and the patch does not contain a single line of comment, plus we generally want to have some textual description of the behaviour (so we can RTFM), not just an implementation without comments. - more comments in the code, per the above. cheers luigi