From owner-svn-src-all@FreeBSD.ORG Sat Jan 17 10:08:57 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 333161065672; Sat, 17 Jan 2009 10:08:57 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id CA2318FC17; Sat, 17 Jan 2009 10:08:56 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [211.166.10.233]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTPS id 9F05C28449; Sat, 17 Jan 2009 18:08:55 +0800 (CST) Received: from localhost (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id 702B7EC42A3; Sat, 17 Jan 2009 18:08:54 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by localhost (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with ESMTP id 5lgfoS3mPeoq; Sat, 17 Jan 2009 18:08:46 +0800 (CST) Received: from charlie.delphij.net (c-67-188-86-134.hsd1.ca.comcast.net [67.188.86.134]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id AB0A8EC418A; Sat, 17 Jan 2009 18:08:43 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=FlGXYuOSEqxbT20/gvuqsSF0AB8M46pT4dQPXQC/Eq6rSVAnp1ytZzMJKEE2m1NXO UIGjmfz8r/N1h58m6USZA== Message-ID: <4971AE26.70406@delphij.net> Date: Sat, 17 Jan 2009 02:08:38 -0800 From: Xin LI Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.19 (X11/20090112) MIME-Version: 1.0 To: obrien@FreeBSD.ORG References: <200901120039.n0C0dMKX043214@svn.freebsd.org> <20090112083144.GA69408@dragon.NUXI.org> In-Reply-To: <20090112083144.GA69408@dragon.NUXI.org> X-Enigmail-Version: 0.95.7 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-stable-7@FreeBSD.ORG, svn-src-stable@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG, Xin LI Subject: Re: svn commit: r187069 - stable/7/sbin/fsck_ffs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jan 2009 10:08:58 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, David, David O'Brien wrote: > On Mon, Jan 12, 2009 at 12:39:22AM +0000, Xin LI wrote: >> Author: delphij >> Date: Mon Jan 12 00:39:22 2009 >> New Revision: 187069 >> URL: http://svn.freebsd.org/changeset/base/187069 >> >> Log: >> MFC revisions 178088 and 179656: Catastrophic recovery mode. > > Hi Xin, > I guess you missed my email to you about this. I was hoping to get an > answer to this before it was MFC'ed. Oops, sorry about that, I think I must have missed the e-mail... > The use of 'C' conflicts with a Juniper Networks change Juniper wants to > push back to FreeBSD. > > For Juniper the -C flag is the "clean" flag. Meaning don't do anything > if the FS is clean, other wise do as full a fsck as possible (vs. just > a "preen" fsck). It is useful as 'fsck -C -y /var' (for instance). > > Do you think your functionality could live under the "-D" (damaged) > option? fsck_ffs already had a "-c" option, or Juniper would have > used that letter. I'm fine with a rename of the option, 'D' sounds a reasonable for my functionality. I have used uppercase to imply that the option is potentially dangerous. One bikeshed candidate: For non-native English speakers, flag 'p' sounds somewhat vague, and 'C' is not quite straightforward either, at the first glance, 'preen' seems to be stronger than 'clean'. Perhaps, 'P' would be a better candidate (a stronger 'preen') for the proposed functionality, just my $0.02 :) Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (FreeBSD) iEYEARECAAYFAklxriYACgkQi+vbBBjt66DwqACfWbN4XfBUcuMalw5MtuxtoeI5 V0gAoLOT/nOy6t5Vy9cP7qqv3VmZtDx9 =0lpr -----END PGP SIGNATURE-----