From owner-svn-src-all@freebsd.org Fri Dec 18 20:54:07 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83D7EA4CEA6; Fri, 18 Dec 2015 20:54:07 +0000 (UTC) (envelope-from kristof@sigsegv.be) Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4EEAB112B; Fri, 18 Dec 2015 20:54:06 +0000 (UTC) (envelope-from kristof@sigsegv.be) Received: from [IPv6:2a02:1811:2419:4e02:296a:ad0f:f23e:3458] (unknown [IPv6:2a02:1811:2419:4e02:296a:ad0f:f23e:3458]) by venus.codepro.be (Postfix) with ESMTPSA id C9D278BBE; Fri, 18 Dec 2015 21:54:04 +0100 (CET) Subject: Re: svn commit: r292309 - in head/sys: modules modules/tcp modules/tcp/fastpath netinet netinet/tcp_stacks Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Content-Type: text/plain; charset=utf-8 From: Kristof Provost X-Checked-By-Nsa: Probably In-Reply-To: <201512160056.tBG0ujqA067178@repo.freebsd.org> Date: Fri, 18 Dec 2015 21:54:03 +0100 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <3E097253-0E8E-4A50-B1BD-8C9A280E6CD0@sigsegv.be> References: <201512160056.tBG0ujqA067178@repo.freebsd.org> To: Randall Stewart X-Mailer: Apple Mail (2.3112) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Dec 2015 20:54:07 -0000 > On 16 Dec 2015, at 01:56, Randall Stewart wrote: >=20 > Author: rrs > Date: Wed Dec 16 00:56:45 2015 > New Revision: 292309 > URL: https://svnweb.freebsd.org/changeset/base/292309 >=20 > Log: > First cut of the modularization of our TCP stack. Still > to do is to clean up the timer handling using the async-drain. > Other optimizations may be coming to go with this. Whats here > will allow differnet tcp implementations (one included). > Reviewed by: jtl, hiren, transports > Sponsored by: Netflix Inc. > Differential Revision: D4055 I suspect this commit broke my machine. I run VIMAGE jails, and see the = following panic as soon as the first jails starts: panic: lock "tcp_func_lock" 0xffffffff81d11dd0 already initialised #0 doadump (textdump=3D1) at pcpu.h:221 #1 0xffffffff80a25b55 in kern_reboot (howto=3D260) at = /usr/src/sys/kern/kern_shutdown.c:364 #2 0xffffffff80a2612b in vpanic (fmt=3D, ap=3D) at /usr/src/sys/kern/kern_shutdown.c:757 #3 0xffffffff80a25f66 in kassert_panic (fmt=3D) at = /usr/src/sys/kern/kern_shutdown.c:647 #4 0xffffffff80a64335 in lock_init (lock=3D0xffffffff81d11dd0, = class=3D0xffffffff8188eb40, name=3D0xffffffff813c4f54 "tcp_func_lock", = type=3D0x0, flags=3D2228224) at /usr/src/sys/kern/subr_lock.c:78 #5 0xffffffff80a231ed in _rw_init_flags (c=3D0xffffffff81d11de8, = name=3D0xffffffff813c4f54 "tcp_func_lock", opts=3D) = at /usr/src/sys/kern/kern_rwlock.c:209 #6 0xffffffff80bfa38f in tcp_init () at = /usr/src/sys/netinet/tcp_subr.c:598 #7 0xffffffff80aa15e8 in vnet_domain_init (arg=3D0xffffffff818ac898) at = /usr/src/sys/kern/uipc_domain.c:175 #8 0xffffffff80b207d7 in vnet_alloc () at /usr/src/sys/net/vnet.c:575 #9 0xffffffff809f1763 in kern_jail_set (td=3D0xfffff80011a244d0, = optuio=3D0xfffff800045d0600, flags=3D1) at = /usr/src/sys/kern/kern_jail.c:1353 #10 0xffffffff809f3151 in sys_jail_set (td=3D0xfffff80011a244d0, = uap=3D0xfffffe0239f02b80) at /usr/src/sys/kern/kern_jail.c:534 #11 0xffffffff80e8911b in amd64_syscall (td=3D0xfffff80011a244d0, = traced=3D0) at subr_syscall.c:135 #12 0xffffffff80e6908b in Xfast_syscall () at = /usr/src/sys/amd64/amd64/exception.S:394 #13 0x0000000800e9f8ca in ?? () That was with r292398, but I=E2=80=99ve just tested r292448 and it=E2=80=99= s still affected. Regards, Kristof