From owner-cvs-all@FreeBSD.ORG Sat Dec 4 19:38:05 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 79ADA16A4CE; Sat, 4 Dec 2004 19:38:05 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2215443D31; Sat, 4 Dec 2004 19:38:05 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.5.50] (adsl-64-171-184-243.dsl.snfc21.pacbell.net [64.171.184.243]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id iB4Jc0C4001510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 4 Dec 2004 11:38:01 -0800 Message-ID: <41B211EA.6070807@root.org> Date: Sat, 04 Dec 2004 11:37:14 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.9 (Windows/20041103) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Alfred Perlstein References: <20041203120940.5573116A515@hub.freebsd.org> <41B091E8.2060807@root.org> <20041204024212.K18185@mail.chesapeake.net> <20041204075743.GL69608@elvis.mu.org> In-Reply-To: <20041204075743.GL69608@elvis.mu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: Jeff Roberson cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Dec 2004 19:38:05 -0000 Alfred Perlstein wrote: > * Jeff Roberson [041203 23:42] wrote: > >>On Fri, 3 Dec 2004, Nate Lawson wrote: >> >> >>>I think that breaking vprint() into multiple lines is not a good idea. >>>Bruce pointed this out to me when I was doing the v_tag changes a while ago. >> >>What's the reason? > > > possibility of it being non-atomically written to the log files? > > -Alfred No, grep and general style considerations. At the risk of ruining the daemon discussion, I think it would be good to have a style(9printf). It would be good to have some more consistency about CaPs, etc. -- Nate