Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 May 2020 18:09:04 +0000 (UTC)
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r361012 - in stable/11/sys: conf modules/drm2/i915kms modules/ipfilter
Message-ID:  <202005131809.04DI94V4000579@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dim
Date: Wed May 13 18:09:03 2020
New Revision: 361012
URL: https://svnweb.freebsd.org/changeset/base/361012

Log:
  MFC r305392:
  
  For kernel builds, instead of suppressing certain clang warnings, make
  them non-fatal, so there is some incentive to fix them eventually.
  
  MFC r333819 (by mmacy):
  
  Silence non-actionable warnings in vendor code
  
  We can't modify vendor code so there's no signal in warnings from it.
  Similarly -Waddress-of-packed-member is not useful on networking code
  as access to packed structures is fundamental to its operation.

Modified:
  stable/11/sys/conf/files
  stable/11/sys/conf/kern.mk
  stable/11/sys/modules/drm2/i915kms/Makefile
  stable/11/sys/modules/ipfilter/Makefile
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/conf/files
==============================================================================
--- stable/11/sys/conf/files	Wed May 13 18:07:37 2020	(r361011)
+++ stable/11/sys/conf/files	Wed May 13 18:09:03 2020	(r361012)
@@ -564,7 +564,7 @@ contrib/ipfilter/netinet/ip_lookup.c optional ipfilter
 contrib/ipfilter/netinet/ip_pool.c optional ipfilter inet \
 	compile-with "${NORMAL_C} -Wno-unused -I$S/contrib/ipfilter"
 contrib/ipfilter/netinet/ip_htable.c optional ipfilter inet \
-	compile-with "${NORMAL_C} -Wno-unused -I$S/contrib/ipfilter"
+	compile-with "${NORMAL_C} -Wno-unused -I$S/contrib/ipfilter ${NO_WTAUTOLOGICAL_POINTER_COMPARE}"
 contrib/ipfilter/netinet/ip_sync.c optional ipfilter inet \
 	compile-with "${NORMAL_C} -Wno-unused -I$S/contrib/ipfilter"
 contrib/ipfilter/netinet/mlfk_ipl.c optional ipfilter inet \

Modified: stable/11/sys/conf/kern.mk
==============================================================================
--- stable/11/sys/conf/kern.mk	Wed May 13 18:07:37 2020	(r361011)
+++ stable/11/sys/conf/kern.mk	Wed May 13 18:09:03 2020	(r361012)
@@ -17,13 +17,14 @@ CWARNFLAGS?=	-Wall -Wredundant-decls -Wnested-externs 
 # kernel where fixing them is more trouble than it is worth, or where there is
 # a false positive.
 .if ${COMPILER_TYPE} == "clang"
-NO_WCONSTANT_CONVERSION=	-Wno-constant-conversion
+NO_WCONSTANT_CONVERSION=	-Wno-error-constant-conversion
 NO_WSHIFT_COUNT_NEGATIVE=	-Wno-shift-count-negative
 NO_WSHIFT_COUNT_OVERFLOW=	-Wno-shift-count-overflow
 NO_WSELF_ASSIGN=		-Wno-self-assign
-NO_WUNNEEDED_INTERNAL_DECL=	-Wno-unneeded-internal-declaration
+NO_WUNNEEDED_INTERNAL_DECL=	-Wno-error-unneeded-internal-declaration
 NO_WSOMETIMES_UNINITIALIZED=	-Wno-error-sometimes-uninitialized
-NO_WCAST_QUAL=			-Wno-cast-qual
+NO_WCAST_QUAL=			-Wno-error-cast-qual
+NO_WTAUTOLOGICAL_POINTER_COMPARE= -Wno-tautological-pointer-compare
 # Several other warnings which might be useful in some cases, but not severe
 # enough to error out the whole kernel build.  Display them anyway, so there is
 # some incentive to fix them eventually.
@@ -34,7 +35,7 @@ CWARNEXTRA?=	-Wno-error-tautological-compare -Wno-erro
 CWARNEXTRA+=	-Wno-error-shift-negative-value
 .endif
 .if ${COMPILER_VERSION} >= 40000
-CWARNEXTRA+=	-Wno-error-address-of-packed-member
+CWARNEXTRA+=	-Wno-address-of-packed-member
 .endif
 .if ${COMPILER_VERSION} >= 100000
 NO_WMISLEADING_INDENTATION=	-Wno-misleading-indentation

Modified: stable/11/sys/modules/drm2/i915kms/Makefile
==============================================================================
--- stable/11/sys/modules/drm2/i915kms/Makefile	Wed May 13 18:07:37 2020	(r361011)
+++ stable/11/sys/modules/drm2/i915kms/Makefile	Wed May 13 18:09:03 2020	(r361012)
@@ -64,3 +64,8 @@ SRCS	+=								\
 CWARNFLAGS.i915_debug.c=	-Wno-unused-function
 CWARNFLAGS.intel_lvds.c=	-Wno-unused
 CWARNFLAGS.intel_tv.c=		-Wno-unused
+CWARNFLAGS.i915_gem.c=		${NO_WTAUTOLOGICAL_POINTER_COMPARE}
+CWARNFLAGS.i915_gem_tiling.c=	${NO_WTAUTOLOGICAL_POINTER_COMPARE}
+CWARNFLAGS.i915_gem_execbuffer.c=	${NO_WTAUTOLOGICAL_POINTER_COMPARE}
+CWARNFLAGS.intel_display.c=	${NO_WTAUTOLOGICAL_POINTER_COMPARE}
+CWARNFLAGS.intel_overlay.c=	${NO_WTAUTOLOGICAL_POINTER_COMPARE}

Modified: stable/11/sys/modules/ipfilter/Makefile
==============================================================================
--- stable/11/sys/modules/ipfilter/Makefile	Wed May 13 18:07:37 2020	(r361011)
+++ stable/11/sys/modules/ipfilter/Makefile	Wed May 13 18:09:03 2020	(r361012)
@@ -21,7 +21,7 @@ CWARNFLAGS.fil.c=		${NO_WSELF_ASSIGN} -Wno-unused
 CWARNFLAGS.ip_auth.c=		-Wno-unused
 CWARNFLAGS.ip_fil_freebsd.c=	-Wno-unused
 CWARNFLAGS.ip_frag.c=		-Wno-unused
-CWARNFLAGS.ip_htable.c=		-Wno-unused
+CWARNFLAGS.ip_htable.c=		-Wno-unused ${NO_WTAUTOLOGICAL_POINTER_COMPARE}
 CWARNFLAGS.ip_dstlist.c=	-Wno-unused
 CWARNFLAGS.ip_lookup.c=		${NO_WSELF_ASSIGN} -Wno-unused
 CWARNFLAGS.ip_nat.c=		-Wno-unused



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202005131809.04DI94V4000579>