From owner-cvs-all@FreeBSD.ORG Fri Mar 2 22:11:57 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 947A616A402; Fri, 2 Mar 2007 22:11:57 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 47FA713C461; Fri, 2 Mar 2007 22:11:57 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l22MBnIp088115; Fri, 2 Mar 2007 15:11:54 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <45E8A117.6070501@samsco.org> Date: Fri, 02 Mar 2007 15:11:35 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: John Baldwin References: <200703021701.l22H1k3M071057@repoman.freebsd.org> <200703021233.28346.jhb@freebsd.org> <45E870B9.4040403@samsco.org> <200703021502.23689.jhb@freebsd.org> In-Reply-To: <200703021502.23689.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Fri, 02 Mar 2007 15:11:55 -0700 (MST) X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Kris Kennaway Subject: Re: cvs commit: src/sys/kern kern_intr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2007 22:11:57 -0000 John Baldwin wrote: > On Friday 02 March 2007 13:45, Scott Long wrote: >> John Baldwin wrote: >>> On Friday 02 March 2007 12:28, Kris Kennaway wrote: >>>> On Fri, Mar 02, 2007 at 10:13:54AM -0700, Scott Long wrote: >>>>> John Baldwin wrote: >>>>>> jhb 2007-03-02 17:01:45 UTC >>>>>> >>>>>> FreeBSD src repository >>>>>> >>>>>> Modified files: >>>>>> sys/kern kern_intr.c >>>>>> Log: >>>>>> - Don't do the interrupt storm protection stuff for software interrupt >>>>>> handlers. >>>>>> - Use pause() when throtting during an interrupt storm. >>>>>> >>>>>> Reported by: kris (1) >>>>>> >>>>>> Revision Changes Path >>>>>> 1.142 +3 -2 src/sys/kern/kern_intr.c >>>>> Actually, having this helped detect a problem with a CAM driver. >>>>> >>>>> Scott >>>> I saw it under normal operation when doing a lot of loopback traffic >>>> on an 8-core. >>> Also, if it ever kicked in for softclock, the system would deadlock. >>> >> Can it be selectively enabled? > > We could do that, sure. The original intent was to prevent a storming > level-triggered PCI interrupt to hang the machine though. It was never > really intended for swi's and having it be on for swi's was an oversight on > my part. > It could be argued that "storming" on the swi is also a bug. It certainly was for a misbehaving driver recently. Scott