From owner-svn-src-all@FreeBSD.ORG Tue May 26 17:15:26 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 127A1AC1; Tue, 26 May 2015 17:15:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E1723A04; Tue, 26 May 2015 17:15:25 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id D9117B91F; Tue, 26 May 2015 13:15:24 -0400 (EDT) From: John Baldwin To: Gleb Smirnoff Cc: Adrian Chadd , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r283538 - head/sys/net80211 Date: Tue, 26 May 2015 13:02:54 -0400 Message-ID: <1496924.Xgdmz2A7b4@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.1-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <20150525193833.GW73119@FreeBSD.org> References: <201505251918.t4PJIGnk004558@svn.freebsd.org> <20150525193833.GW73119@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 26 May 2015 13:15:24 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2015 17:15:26 -0000 On Monday, May 25, 2015 10:38:33 PM Gleb Smirnoff wrote: > On Mon, May 25, 2015 at 07:18:16PM +0000, Adrian Chadd wrote: > A> * kill M_WAITOK - some platforms just don't want you to use it > > Actually all functions called in device attach context or in > syscall context should use M_WAITOK. This makes API more robust and > simplifies code a lot. > > Can we achieve portability without losing this nice feature of > FreeBSD? I agree with this general policy. There are several places that currently use M_NOWAIT (e.g. new-bus) that could safely use M_WAITOK instead in many cases (if not always). -- John Baldwin