From owner-freebsd-current@FreeBSD.ORG Sun Oct 21 18:58:18 2007 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6263E16A419 for ; Sun, 21 Oct 2007 18:58:18 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 3141B13C4B8 for ; Sun, 21 Oct 2007 18:58:18 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l9LIw3hv011955; Sun, 21 Oct 2007 12:58:03 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <471BA12B.7060302@samsco.org> Date: Sun, 21 Oct 2007 12:57:47 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Julian Elischer References: <471AD8B7.2000007@elischer.org> In-Reply-To: <471AD8B7.2000007@elischer.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Sun, 21 Oct 2007 12:58:04 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: FreeBSD Current Subject: Re: supporting old code in -current.. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2007 18:58:18 -0000 Julian Elischer wrote: > > In the following files (and their modules) we have the following in > -current. > > > src/sys/dev/aic7xxx/aic_osm_lib.h > src/sys/dev/mpt/mpt.h > > #if __FreeBSD_version > 500005 > [...] > #else > [blah] > #endif > > is this worth maintaining? > > are the maintainers for mpt and aic supporting 4.x with the same sources > somewhere? > At one point, the code was shared between different OS versions for both of the these drivers. Adding locking hurt that a bit, and I mostly consider 4.x compat to be an obstacle at this point. I don't care if this gets broken by your kthread/kproc changes. Scott