From nobody Wed Oct 1 09:38:57 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cc8y96NyLz69GZk; Wed, 01 Oct 2025 09:38:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cc8y93qs3z3HBp; Wed, 01 Oct 2025 09:38:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lGOrBsHh0lbld078J9neJhkf6tTfXEPbbXsXic7m/Nk=; b=QwlGa+eQuf/jhtXkz2Z0MeRxxv/IQPSpMk+lNlQ5k+snw7Jr/tAR0MUP8onWOxKslpZzth fhChGXbvgL8OPNza0adsZ6XAX+TBlGudMzTFOx94YZFX4G80SJ7LGahSTAAAwcQUk7KT4z WND+FhGsZSPevxkS565tgSJ7XoGX0Hm6eTvzgKO+ghX//9oZ+hCd93MKPEsYAHdsRSNylx lomXT150RQ1dI88vrGKcAF07Eno7F5JP+XA20CYH9tbw4J673hpzCDPbmwNMZjoXoXm0aW w2EIVZsnFtD8tmJ/Si2DLva3oLH+saPF3ZtLAp0my0c2qdHMWMs47Ia9XTLpNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lGOrBsHh0lbld078J9neJhkf6tTfXEPbbXsXic7m/Nk=; b=y16HT3ZyvkD4L/zvwQvAsbLgKuEo11M7oy1gYlytFZmo4ApqCAhiB1Gd3YLrXfh50sSM2S Uhiz8dcw0Q6izvH3FYW2QsiU35eDaIcJ14VoLoa3YyYBUYaQBeTbe3URsAKe6rYgmAxbbV VFkTqrgsNMietZmDsD3kcE4L887Jwqn/U/6r3+m1Zd55LFdsGLegFky+n21hMIeWuS5+MT DYWuQpP9yloBU92Yj6dwEmAOghMr2enCLs1NGdMZaHv1K5c8Xbu3WhTPHupvxX19lHvZdH OogNEg6USGvIHXJlKSNO4+VBOeOwyxeg/9wDD4OjIbLA3e+fSRcc6XyZuaONpg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759311537; a=rsa-sha256; cv=none; b=agfVGvxN7ufwhDnwvW8fsEN9wnFG/3qOD7ddS3z8Yd/YH7LGhzvAtk9QS6BFMIfxVwes3v znQZbu0p5Dd/AMTQOhyEkRRVeuLz1phVluGrx4qwmH5H9Y6mVss7jIv/sD0Vw1Gyq5wWDs mgjWF33j6SV0mRjlW0Cf5fdHCA043cTXEmEclPGYVGZ3n+U4pK4c4VSO7jTgcTtz6n5A9/ mzsoGnaIUVxhDbPMw07Hwq9ExWf7l/zqFTBJrZBID/wKTf1x6i/ECVe+gy2DiIbBSoJJ5X ZcPAPC/VplRzPM/nhCybi0jO1I/sp2z+AGrtuKIgzkEypU25PBBnQyJAKt25vQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cc8y932szz2JJ; Wed, 01 Oct 2025 09:38:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5919cvOn016713; Wed, 1 Oct 2025 09:38:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5919cv8a016710; Wed, 1 Oct 2025 09:38:57 GMT (envelope-from git) Date: Wed, 1 Oct 2025 09:38:57 GMT Message-Id: <202510010938.5919cv8a016710@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org, dev-commits-src-branches@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: e73cc0abe140 - stable/15 - ng_tty: don't increment m_data List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: e73cc0abe1401ff12efffa09d96d3a212608f08a Auto-Submitted: auto-generated The branch stable/15 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=e73cc0abe1401ff12efffa09d96d3a212608f08a commit e73cc0abe1401ff12efffa09d96d3a212608f08a Author: Ahmad Khalifa AuthorDate: 2025-09-24 15:01:57 +0000 Commit: Ahmad Khalifa CommitDate: 2025-10-01 09:37:35 +0000 ng_tty: don't increment m_data Stop incrementing m_data so the callee can read the mbuf. MFC after: 3 days Reviewed by: glebius Differential Revision: https://reviews.freebsd.org/D52702 (cherry picked from commit 57d5a8feda3fd25a650eaab5998db13633d62d2d) --- sys/netgraph/ng_tty.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c index 6f8667c664bb..c7d8a1b64eac 100644 --- a/sys/netgraph/ng_tty.c +++ b/sys/netgraph/ng_tty.c @@ -485,9 +485,7 @@ ngt_rint(struct tty *tp, char c, int flags) } /* Add char to mbuf */ - *mtod(m, u_char *) = c; - m->m_data++; - m->m_len++; + *(u_char *)mtodo(m, m->m_len++) = c; m->m_pkthdr.len++; /* Ship off mbuf if it's time */