Date: Thu, 22 Jan 2015 19:30:19 -0500 From: Ryan Stone <rysto32@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: Re: Sleeping thread held mutex in vm_pageout_oom() Message-ID: <CAFMmRNziuN_jWyeNjdcB8yzM6uVM8_BO_h0U1Gphn%2B13E-7JcA@mail.gmail.com> In-Reply-To: <20150122083514.GU42409@kib.kiev.ua> References: <CAFMmRNxz252HMWWBmRf=Z69zh2_w9cD5e1AZGeizyagKezm2Hw@mail.gmail.com> <20150120083212.GC42409@kib.kiev.ua> <CAFMmRNz6Dof%2B95zyekUFEbmcqeFSqXr96Y7BUZpqJ9z0XoWVOA@mail.gmail.com> <20150122083514.GU42409@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Other than the redundant braces on the else below, this looks good. I
tested it today and saw no further problems.
I do think that a WITNESS_WARN() in vmspace_free() would be
appropriate. I'll give that a sanity here to make sure that nothing
explodes and if everything looks ok, I'll commit it.
> @@ -1573,16 +1602,19 @@ vm_pageout_oom(int shortage)
> */
> if (size > bigsize) {
> if (bigproc != NULL)
> - PROC_UNLOCK(bigproc);
> + PRELE(bigproc);
> bigproc = p;
> bigsize = size;
> - } else
> - PROC_UNLOCK(p);
> + } else {
> + PRELE(p);
> + }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFMmRNziuN_jWyeNjdcB8yzM6uVM8_BO_h0U1Gphn%2B13E-7JcA>