From owner-svn-src-stable-10@freebsd.org  Fri Mar  3 14:35:21 2017
Return-Path: <owner-svn-src-stable-10@freebsd.org>
Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4BA3FCF5A4C;
 Fri,  3 Mar 2017 14:35:21 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id EB54C12B5;
 Fri,  3 Mar 2017 14:35:19 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA26957;
 Fri, 03 Mar 2017 16:35:18 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1cjoIf-0009rN-RL; Fri, 03 Mar 2017 16:35:17 +0200
Subject: Re: svn commit: r314594 - stable/10/sys/modules/mlx5
To: Hans Petter Selasky <hps@selasky.org>, src-committers@FreeBSD.org,
 svn-src-all@FreeBSD.org, svn-src-stable@FreeBSD.org,
 svn-src-stable-10@FreeBSD.org
References: <201703031206.v23C6XTF055972@repo.freebsd.org>
 <bdb13a79-d204-7e15-65b2-6e2f45dd4560@selasky.org>
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <915cdd8f-0f12-0bb1-9c8d-e4813e275141@FreeBSD.org>
Date: Fri, 3 Mar 2017 16:34:22 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <bdb13a79-d204-7e15-65b2-6e2f45dd4560@selasky.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-stable-10@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for only the 10-stable src tree
 <svn-src-stable-10.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable-10>, 
 <mailto:svn-src-stable-10-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable-10/>
List-Post: <mailto:svn-src-stable-10@freebsd.org>
List-Help: <mailto:svn-src-stable-10-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable-10>, 
 <mailto:svn-src-stable-10-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Mar 2017 14:35:21 -0000

On 03/03/2017 16:18, Hans Petter Selasky wrote:
> On 03/03/17 13:06, Andriy Gapon wrote:
>> Author: avg
>> Date: Fri Mar  3 12:06:33 2017
>> New Revision: 314594
>> URL: https://svnweb.freebsd.org/changeset/base/314594
>>
>> Log:
>>   mlx5 module: remove include path that doesn't exist in this branch
>>
>>   This is a direct commit.
>>   It allows the module to be compiled with the base gcc.
>>
>> Modified:
>>   stable/10/sys/modules/mlx5/Makefile
>>
>> Modified: stable/10/sys/modules/mlx5/Makefile
>> ==============================================================================
>> --- stable/10/sys/modules/mlx5/Makefile    Fri Mar  3 12:03:50 2017    (r314593)
>> +++ stable/10/sys/modules/mlx5/Makefile    Fri Mar  3 12:06:33 2017    (r314594)
>> @@ -30,7 +30,6 @@ device_if.h bus_if.h vnode_if.h pci_if.h
>>  SRCS+= linux_compat.c linux_radix.c linux_idr.c
>>
>>  CFLAGS+= -I${.CURDIR}/../../ofed/include
>> -CFLAGS+= -I${.CURDIR}/../../compat/linuxkpi/common/include
>>
>>  .include <bsd.kmod.mk>
>>
> 
> Hi,
> 
> Which version of GCC is this?

gcc version 4.2.1 20070831 patched [FreeBSD]
That is, the compiler that you get when clang is disabled.

> Do you want me to check for this kind of errors before committing or are you
> fine cleaning up every now and then? Currently the mlx4/mlx5 code is only tested
> with the in-base compiler.

Checking with a non-default compiler is probably too much a burden for anyone
who doesn't use it regularly.

-- 
Andriy Gapon