From owner-svn-src-head@freebsd.org Fri Mar 10 18:12:28 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7F001D0645B; Fri, 10 Mar 2017 18:12:28 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 22A10D8C; Fri, 10 Mar 2017 18:12:27 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v2AICNC8013418; Fri, 10 Mar 2017 10:12:23 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v2AICMt5013417; Fri, 10 Mar 2017 10:12:22 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201703101812.v2AICMt5013417@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r311849 - in head: . sys/amd64/conf sys/arm64/conf sys/conf sys/dev/e1000 sys/i386/conf sys/mips/conf sys/modules sys/modules/em sys/modules/igb sys/powerpc/conf In-Reply-To: To: Sean Bruno Date: Fri, 10 Mar 2017 10:12:22 -0800 (PST) CC: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 18:12:28 -0000 -- Start of PGP signed section. [ Charset windows-1252 unsupported, converting... ] > > > On 02/15/17 03:06, Roger Pau Monn? wrote: > > On Tue, Jan 10, 2017 at 03:23:22AM +0000, Sean Bruno wrote: > >> Author: sbruno > >> Date: Tue Jan 10 03:23:22 2017 > >> New Revision: 311849 > >> URL: https://svnweb.freebsd.org/changeset/base/311849 > >> > >> Log: > >> Migrate e1000 to the IFLIB framework: > >> - em(4) igb(4) and lem(4) > >> - deprecate the igb device from kernel configurations > >> - create a symbolic link in /boot/kernel from if_em.ko to if_igb.ko What about if you make that a hard link? Would that fix the CP issue too? > > > > This linking causes mfsBSD to choke when building an image from HEAD. It tries > > to issue the following command: > > > > ${_v}${CP} -rp ${_BOOTDIR}/kernel ${WRKDIR}/disk/boot > > > > Which fails when finding the symbol link. I can send a patch to change that to > > -Rp, which would work fine, but wouldn't it be better to either completely > > remove if_igb.ko, or simply copy if_em.ko to if_igb.ko? > > > > I'm wondering if for example anyone strips down it's /boot/kernel/ manually, by > > removing unused modules, and what would happen if if_em.ko is removed but not > > if_igb.ko. > > > > Roger. > > > > > > Well, this was my naive attempt to make upgrades for users to be > non-eventful in the event they have "if_igb_load=YES" in their > loader.conf instead of having it built into their kernel. > > If the -Rp works, I'll add that instead. > > sean > -- End of PGP section, PGP failed! -- Rod Grimes rgrimes@freebsd.org